Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): handling AOM properties on anchor tags #488

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

davidturissini
Copy link
Contributor

Details

Allows AOM properties to be set imperatively on anchor tags

Fixes #487

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 0e65ac1 | Target commit: 46d57b7

lwc-engine-benchmark

table-append-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table/append/1k duration 159.40 (± 6.40 ms) 161.30 (± 5.90 ms) -1.19% 👌
table-clear-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table/clear/1k duration 13.15 (± 0.85 ms) 13.20 (± 0.70 ms) -0.38% 👌
table-create-10k metric base(0e65ac1) target(46d57b7) trend
benchmark-table/create/10k duration 876.60 (± 6.90 ms) 892.70 (± 7.20 ms) -1.84% 👎
table-create-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table/create/1k duration 107.30 (± 2.50 ms) 105.75 (± 1.95 ms) 1.44% 👍
table-update-10th-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table/update-10th/1k duration 92.95 (± 5.15 ms) 92.10 (± 4.80 ms) 0.91% 👌
tablecmp-append-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-component/append/1k duration 248.10 (± 5.70 ms) 239.60 (± 4.10 ms) 3.43% 👍
tablecmp-clear-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-component/clear/1k duration 39.70 (± 1.60 ms) 38.00 (± 1.70 ms) 4.28% 👍
tablecmp-create-10k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-component/create/10k duration 1629.80 (± 11.50 ms) 1612.10 (± 8.60 ms) 1.09% 👍
tablecmp-create-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-component/create/1k duration 179.60 (± 4.80 ms) 173.80 (± 4.20 ms) 3.23% 👍
tablecmp-update-10th-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-component/update-10th/1k duration 81.75 (± 4.40 ms) 80.30 (± 4.20 ms) 1.77% 👌
wc-append-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-wc/append/1k duration 271.10 (± 16.90 ms) 282.30 (± 4.60 ms) -4.13% 👎
wc-clear-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-wc/clear/1k duration 40.10 (± 1.55 ms) 38.30 (± 1.60 ms) 4.49% 👍
wc-create-10k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-wc/create/10k duration 2087.00 (± 8.90 ms) 2080.00 (± 10.50 ms) 0.34% 👍
wc-create-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-wc/create/1k duration 218.60 (± 5.40 ms) 223.40 (± 3.90 ms) -2.20% 👎
wc-update-10th-1k metric base(0e65ac1) target(46d57b7) trend
benchmark-table-wc/update-10th/1k duration 82.60 (± 3.90 ms) 82.20 (± 7.00 ms) 0.48% 👌

@diervo diervo merged commit 575f881 into master Jul 10, 2018
@diervo diervo deleted the dturissini/shadow-root-anchor-host-fix branch July 10, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants