fix(engine): wrapping assert for dev-only

[caridy]

Fix Perf Regression

Details

• assert lib was leaking into prod-mode

Does this PR introduce a breaking change?

• No

[caridy]

I have checked the build manually, and prod does not have the assert lib anymore, but we need to add a linter rule on the engine so we don't accidentally leak this anymore.

[salesforce-best-lwc-internal]

Benchmark results

Base commit: e66e0e9 | Target commit: 5defe61

lwc-engine-benchmark

table-append-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table/append/1k	duration	147.90 (± 6.30 ms)	146.50 (± 5.30 ms)	0.95% 👌

table-clear-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table/clear/1k	duration	11.90 (± 0.60 ms)	11.90 (± 0.50 ms)	0.00% 👌

table-create-10k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table/create/10k	duration	847.15 (± 4.30 ms)	848.50 (± 5.20 ms)	-0.16% 👌

table-create-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table/create/1k	duration	102.50 (± 1.90 ms)	102.30 (± 1.90 ms)	0.20% 👌

table-update-10th-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table/update-10th/1k	duration	89.00 (± 4.90 ms)	84.90 (± 5.80 ms)	4.61% 👌

tablecmp-append-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-component/append/1k	duration	226.20 (± 4.70 ms)	228.70 (± 3.90 ms)	-1.11% 👎

tablecmp-clear-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-component/clear/1k	duration	36.00 (± 1.90 ms)	36.30 (± 1.80 ms)	-0.83% 👌

tablecmp-create-10k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-component/create/10k	duration	1532.20 (± 12.10 ms)	1558.40 (± 8.00 ms)	-1.71% 👎

tablecmp-create-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-component/create/1k	duration	171.80 (± 3.90 ms)	170.50 (± 5.10 ms)	0.76% 👌

tablecmp-update-10th-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-component/update-10th/1k	duration	78.90 (± 3.90 ms)	76.80 (± 4.30 ms)	2.66% 👌

wc-append-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-wc/append/1k	duration	263.00 (± 7.10 ms)	252.60 (± 13.30 ms)	3.95% 👌

wc-clear-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-wc/clear/1k	duration	36.50 (± 1.60 ms)	36.20 (± 1.00 ms)	0.82% 👌

wc-create-10k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-wc/create/10k	duration	1993.90 (± 5.70 ms)	2026.70 (± 6.90 ms)	-1.65% 👎

wc-create-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-wc/create/1k	duration	210.70 (± 3.10 ms)	210.10 (± 4.70 ms)	0.28% 👌

wc-update-10th-1k	metric	base(e66e0e9)	target(5defe61)	trend
benchmark-table-wc/update-10th/1k	duration	76.40 (± 4.10 ms)	77.50 (± 3.70 ms)	-1.44% 👌

[caridy]

@pmdartus @diervo you can see a ~4% improvements on the update and append mechanism.

[caridy]

CI is flaky today! timeout