fix(compiler): correct module-resolver error messages @bug W-5192589@ #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsBase commit: |
pmdartus
requested changes
Jul 31, 2018
|
|
||
| const { diagnostics, result, success } = await compile(COMPILER_CONFIG_BASEDIR); | ||
| expect(success).toBe(false); | ||
| console.log(diagnostics); |
| const { diagnostics, result, success } = await compile(COMPILER_CONFIG_BASEDIR); | ||
| expect(success).toBe(false); | ||
| console.log(diagnostics); | ||
| expect(diagnostics[0].level).toBe(0); |
There was a problem hiding this comment.
Use Diagnostive.Error instead of 0.
| "foo.js": ` | ||
| import { Element } from 'engine'; | ||
| export default class Test extends Element {}`, | ||
| "foo.html": `<template><p>Component Template</p></template>`, |
There was a problem hiding this comment.
No need to have an html file if the entry point can't be resolved.
| namespace: "x", | ||
| files: { | ||
| "foo.js": ` | ||
| import { Element } from 'engine'; |
There was a problem hiding this comment.
Keep the test minimal remove the entry file content empty.
| export default class Test extends Element { | ||
| get mytitle() { return nested; } | ||
| }`, | ||
| "foo.html": `<template><p>Component Template</p></template>`, |
| files: { | ||
| "foo.js": ` | ||
| import { Element } from 'engine'; | ||
| import { nested } from './lib/foo'; |
There was a problem hiding this comment.
Keep the test minimal and only keep an import statement.
import './lib/foo';
pmdartus
reviewed
Jul 31, 2018
| name: "foo", | ||
| namespace: "x", | ||
| files: { | ||
| "foo.js": ` |
There was a problem hiding this comment.
Can you also make this test minimal?
pmdartus
approved these changes
Jul 31, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Edit the error messages to provide a more clear description of the issue.
Does this PR introduce a breaking change?