Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow both "lwc" and "engine" sources #560

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Aug 5, 2018

Details

Allow both forms:

// legacy
import { Element } form "engine";

// new
import { LightningElement } from "lwc";

Refactored some tests to use the new names

Does this PR introduce a breaking change?

  • Yes
  • No

@diervo diervo changed the title Allow both "lwc" and "engine" sources feat: allow both "lwc" and "engine" sources Aug 5, 2018
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: b982bd8 | Target commit: d62db80

lwc-engine-benchmark

table-append-1k metric base(b982bd8) target(d62db80) trend
benchmark-table/append/1k duration 151.40 (± 4.70 ms) 148.10 (± 4.20 ms) 2.18% 👌
table-clear-1k metric base(b982bd8) target(d62db80) trend
benchmark-table/clear/1k duration 11.80 (± 0.60 ms) 11.40 (± 0.60 ms) 3.39% 👌
table-create-10k metric base(b982bd8) target(d62db80) trend
benchmark-table/create/10k duration 848.70 (± 4.30 ms) 854.40 (± 3.20 ms) -0.67% 👎
table-create-1k metric base(b982bd8) target(d62db80) trend
benchmark-table/create/1k duration 107.70 (± 1.50 ms) 105.40 (± 1.70 ms) 2.14% 👍
table-update-10th-1k metric base(b982bd8) target(d62db80) trend
benchmark-table/update-10th/1k duration 92.50 (± 3.70 ms) 83.60 (± 2.80 ms) 9.62% 👍
tablecmp-append-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-component/append/1k duration 229.90 (± 4.60 ms) 225.20 (± 5.50 ms) 2.04% 👍
tablecmp-clear-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-component/clear/1k duration 34.95 (± 1.80 ms) 35.10 (± 1.80 ms) -0.43% 👌
tablecmp-create-10k metric base(b982bd8) target(d62db80) trend
benchmark-table-component/create/10k duration 1578.40 (± 13.50 ms) 1557.40 (± 10.10 ms) 1.33% 👍
tablecmp-create-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-component/create/1k duration 177.20 (± 3.60 ms) 172.90 (± 3.10 ms) 2.43% 👍
tablecmp-update-10th-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-component/update-10th/1k duration 78.05 (± 4.35 ms) 79.10 (± 4.30 ms) -1.35% 👌
wc-append-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-wc/append/1k duration 261.30 (± 8.30 ms) 252.80 (± 12.30 ms) 3.25% 👌
wc-clear-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-wc/clear/1k duration 35.70 (± 1.00 ms) 34.90 (± 1.00 ms) 2.24% 👌
wc-create-10k metric base(b982bd8) target(d62db80) trend
benchmark-table-wc/create/10k duration 2030.40 (± 9.10 ms) 1968.70 (± 6.20 ms) 3.04% 👍
wc-create-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-wc/create/1k duration 213.20 (± 4.90 ms) 220.60 (± 3.40 ms) -3.47% 👎
wc-update-10th-1k metric base(b982bd8) target(d62db80) trend
benchmark-table-wc/update-10th/1k duration 77.10 (± 3.50 ms) 75.90 (± 3.20 ms) 1.56% 👌

@@ -1,4 +1,4 @@
const { LWC_PACKAGE_ALIAS } = require('./constants');
const { LWC_PACKAGE_ALIAS, LWC_PACKAGE_ALIAS_LEGACY, LWC_PACKAGE_EXPORTS } = require('./constants');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains the important forward looking changes.

@diervo diervo merged commit 501586c into master Aug 6, 2018
@diervo diervo deleted the dval/upgradeNamingLWC branch August 6, 2018 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant