Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel-plugin-transform-lwc-class): add component tag name support #621

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented Sep 5, 2018

Details

Add GVP processing logic for component tag name

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 8060daa | Target commit: 76e344a

lwc-engine-benchmark

table-append-1k metric base(8060daa) target(76e344a) trend
benchmark-table/append/1k duration 144.40 (± 6.60 ms) 140.50 (± 4.70 ms) 2.70% 👌
table-clear-1k metric base(8060daa) target(76e344a) trend
benchmark-table/clear/1k duration 11.20 (± 0.60 ms) 11.20 (± 0.70 ms) 0.00% 👌
table-create-10k metric base(8060daa) target(76e344a) trend
benchmark-table/create/10k duration 841.50 (± 5.80 ms) 835.50 (± 4.80 ms) 0.71% 👍
table-create-1k metric base(8060daa) target(76e344a) trend
benchmark-table/create/1k duration 105.00 (± 1.10 ms) 105.40 (± 2.00 ms) -0.38% 👌
table-update-10th-1k metric base(8060daa) target(76e344a) trend
benchmark-table/update-10th/1k duration 83.50 (± 2.30 ms) 85.00 (± 3.60 ms) -1.80% 👌
tablecmp-append-1k metric base(8060daa) target(76e344a) trend
benchmark-table-component/append/1k duration 220.50 (± 6.60 ms) 218.70 (± 6.00 ms) 0.82% 👌
tablecmp-clear-1k metric base(8060daa) target(76e344a) trend
benchmark-table-component/clear/1k duration 18.35 (± 1.65 ms) 17.10 (± 2.10 ms) 6.81% 👍
tablecmp-create-10k metric base(8060daa) target(76e344a) trend
benchmark-table-component/create/10k duration 1513.20 (± 7.30 ms) 1528.00 (± 11.40 ms) -0.98% 👎
tablecmp-create-1k metric base(8060daa) target(76e344a) trend
benchmark-table-component/create/1k duration 173.30 (± 3.40 ms) 173.90 (± 4.60 ms) -0.35% 👌
tablecmp-update-10th-1k metric base(8060daa) target(76e344a) trend
benchmark-table-component/update-10th/1k duration 77.50 (± 3.40 ms) 79.50 (± 3.80 ms) -2.58% 👌
wc-append-1k metric base(8060daa) target(76e344a) trend
benchmark-table-wc/append/1k duration 259.80 (± 4.60 ms) 260.80 (± 3.70 ms) -0.38% 👌
wc-clear-1k metric base(8060daa) target(76e344a) trend
benchmark-table-wc/clear/1k duration 26.30 (± 2.90 ms) 26.50 (± 2.20 ms) -0.76% 👌
wc-create-10k metric base(8060daa) target(76e344a) trend
benchmark-table-wc/create/10k duration 2008.60 (± 9.70 ms) 1974.40 (± 6.00 ms) 1.70% 👍
wc-create-1k metric base(8060daa) target(76e344a) trend
benchmark-table-wc/create/1k duration 213.50 (± 5.00 ms) 212.30 (± 4.60 ms) 0.56% 👌
wc-update-10th-1k metric base(8060daa) target(76e344a) trend
benchmark-table-wc/update-10th/1k duration 74.50 (± 3.50 ms) 76.30 (± 3.05 ms) -2.42% 👌

@apapko apapko merged commit 57cae0c into master Sep 5, 2018
@apapko apapko deleted the apapko/component-tag-name-support branch September 5, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants