Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrading babel #653

Merged
merged 3 commits into from
Sep 19, 2018
Merged

fix: upgrading babel #653

merged 3 commits into from
Sep 19, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Sep 18, 2018 •
edited
Loading

Details

  • Upgrading to babel 7.1.0
  • Upgrading compat to match as well

trevor-bliss
trevor-bliss approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@trevor-bliss trevor-bliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to remove the only in the test before submitting

packages/babel-plugin-transform-lwc-class/src/__tests__/component.spec.js Outdated
@@ -2,7 +2,7 @@ const pluginTest = require('./utils/test-transform').pluginTest(
require('../index')
);

describe('Element import', () => {
describe.only('Element import', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove only

diervo
diervo commented Sep 18, 2018
View reviewed changes
packages/babel-plugin-transform-lwc-class/src/metadata.js
@@ -47,8 +47,9 @@ module.exports = function () {
function extractLWCDecorator(node) {
if (node.decorators) {
for (const decorator of node.decorators) {
if (isLWCDecorator(decorator.callee.name)) {
return decorator.callee.name;
const name = decorator.expression.name || decorator.expression.callee.name;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apapko this was the issue

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: d1d3fa5 | Target commit: 6892eea

lwc-engine-benchmark

table-append-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table/append/1k duration 163.35 (±3.70 ms) 171.90 (±3.40 ms) +8.5ms (5.2%) 👎
table-clear-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table/clear/1k duration 12.60 (±0.80 ms) 13.75 (±0.85 ms) +1.2ms (9.1%) 👎
table-create-10k metric base(d1d3fa5) target(6892eea) trend
benchmark-table/create/10k duration 930.85 (±6.65 ms) 969.35 (±9.00 ms) +38.5ms (4.1%) 👎
table-create-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table/create/1k duration 112.25 (±2.05 ms) 115.95 (±2.55 ms) +3.7ms (3.3%) 👎
table-update-10th-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table/update-10th/1k duration 86.70 (±1.70 ms) 89.95 (±3.45 ms) +3.3ms (3.7%) 👎
tablecmp-append-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-component/append/1k duration 249.15 (±6.40 ms) 249.15 (±10.35 ms) 0.0ms (0.0%) 👌
tablecmp-clear-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-component/clear/1k duration 21.15 (±2.05 ms) 21.90 (±2.50 ms) +0.8ms (3.5%) 👌
tablecmp-create-10k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-component/create/10k duration 1682.05 (±13.55 ms) 1726.05 (±8.85 ms) +44.0ms (2.6%) 👎
tablecmp-create-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-component/create/1k duration 193.00 (±5.20 ms) 192.10 (±4.75 ms) -0.9ms (0.5%) 👌
tablecmp-update-10th-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-component/update-10th/1k duration 86.65 (±5.25 ms) 87.00 (±6.95 ms) +0.3ms (0.4%) 👌
wc-append-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-wc/append/1k duration 284.80 (±14.55 ms) 281.15 (±20.30 ms) -3.7ms (1.3%) 👌
wc-clear-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-wc/clear/1k duration 30.45 (±2.95 ms) 31.60 (±2.70 ms) +1.2ms (3.8%) 👌
wc-create-10k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-wc/create/10k duration 2121.80 (±10.70 ms) 2215.70 (±12.75 ms) +93.9ms (4.4%) 👎
wc-create-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-wc/create/1k duration 227.55 (±4.65 ms) 233.95 (±6.90 ms) +6.4ms (2.8%) 👎
wc-update-10th-1k metric base(d1d3fa5) target(6892eea) trend
benchmark-table-wc/update-10th/1k duration 86.30 (±5.35 ms) 88.50 (±6.65 ms) +2.2ms (2.5%) 👌

pmdartus
pmdartus reviewed Sep 18, 2018
View reviewed changes
packages/lwc-jest-transformer/src/transforms/__tests__/utils/test-transform.js Outdated
@@ -7,7 +7,12 @@ const baseConfig = {
babelrc: false,
filename: 'test.js',
parserOpts: {
plugins: ['*'],
plugins: [
['asyncGenerators', {}],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support async generators: https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: d1d3fa5 | Target commit: 991a018

lwc-engine-benchmark

table-append-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table/append/1k duration 163.35 (±3.70 ms) 164.45 (±4.80 ms) +1.1ms (0.7%) 👌
table-clear-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table/clear/1k duration 12.60 (±0.80 ms) 12.45 (±0.85 ms) -0.2ms (1.2%) 👌
table-create-10k metric base(d1d3fa5) target(991a018) trend
benchmark-table/create/10k duration 930.85 (±6.65 ms) 939.00 (±10.00 ms) +8.1ms (0.9%) 👎
table-create-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table/create/1k duration 112.25 (±2.05 ms) 112.10 (±2.60 ms) -0.2ms (0.1%) 👌
table-update-10th-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table/update-10th/1k duration 86.70 (±1.70 ms) 87.15 (±2.25 ms) +0.5ms (0.5%) 👌
tablecmp-append-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-component/append/1k duration 249.15 (±6.40 ms) 245.75 (±6.75 ms) -3.4ms (1.4%) 👍
tablecmp-clear-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-component/clear/1k duration 21.15 (±2.05 ms) 21.60 (±2.20 ms) +0.5ms (2.1%) 👌
tablecmp-create-10k metric base(d1d3fa5) target(991a018) trend
benchmark-table-component/create/10k duration 1682.05 (±13.55 ms) 1690.60 (±18.80 ms) +8.5ms (0.5%) 👌
tablecmp-create-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-component/create/1k duration 193.00 (±5.20 ms) 186.60 (±5.50 ms) -6.4ms (3.3%) 👍
tablecmp-update-10th-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-component/update-10th/1k duration 86.65 (±5.25 ms) 83.30 (±3.85 ms) -3.3ms (3.9%) 👍
wc-append-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-wc/append/1k duration 284.80 (±14.55 ms) 270.75 (±18.65 ms) -14.1ms (4.9%) 👍
wc-clear-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-wc/clear/1k duration 30.45 (±2.95 ms) 29.15 (±2.50 ms) -1.3ms (4.3%) 👍
wc-create-10k metric base(d1d3fa5) target(991a018) trend
benchmark-table-wc/create/10k duration 2121.80 (±10.70 ms) 2153.20 (±11.00 ms) +31.4ms (1.5%) 👎
wc-create-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-wc/create/1k duration 227.55 (±4.65 ms) 224.40 (±5.40 ms) -3.2ms (1.4%) 👌
wc-update-10th-1k metric base(d1d3fa5) target(991a018) trend
benchmark-table-wc/update-10th/1k duration 86.30 (±5.35 ms) 83.55 (±4.65 ms) -2.8ms (3.2%) 👌

@diervo diervo merged commit ee1e513 into master Sep 19, 2018
@diervo diervo deleted the dval/compatUpdate branch September 19, 2018 04:34
@pmdartus pmdartus mentioned this pull request Oct 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmdartus pmdartus pmdartus left review comments

@apapko apapko apapko approved these changes

@trevor-bliss trevor-bliss trevor-bliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diervo @trevor-bliss @pmdartus @apapko