fix(engine): fixes #663 - unique keys for slotted elements #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Sep 21, 2018
| @@ -573,7 +573,12 @@ export function allocateInSlot(vm: VM, children: VNodes) { | |||
| const data = (vnode.data as VNodeData); | |||
| const slotName = ((data.attrs && data.attrs.slot) || '') as string; | |||
| const vnodes: VNodes = cmpSlots[slotName] = cmpSlots[slotName] || []; | |||
| vnodes.push(vnode); | |||
There was a problem hiding this comment.
we were using dot notation here :(
caridy
commented
Sep 21, 2018
| // which might have similar keys. Each vnode will always have a key that | ||
| // starts with a numeric character from compiler. In this case, we add a unique | ||
| // notation for slotted vnodes keys, e.g.: `@foo:1:1` | ||
| vnode.key = `@${slotName}:${vnode.key}`; |
There was a problem hiding this comment.
this is the re-keying routine, only for fallback mode.
Benchmark resultsBase commit: lwc-engine-benchmark-ie11
lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark-ie11
lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark-ie11
lwc-engine-benchmark
|
ekashida
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes an issue described in #663. It is a very hard bug to reproduce, but basically, there is a chance that, when in fallback mode (synthetic shadow), a key of an slotted element matches the key assigned by the compiler to the vnode in the default slot content, in which case the diffing algo will attempt to reuse the element, which can have old kind of weird effects.
This PR, guarantees that the slotted elements will always get re-keyed when needed.
Does this PR introduce a breaking change?