Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(benchmarks): Migrate remaining benchmark to best #67

Merged
merged 7 commits into from
Feb 6, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 6, 2018

Details

Upgrade the old benchmarks to use best.

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: a5ad51d | Target commit: ffc2e7d

benchmark base(a5ad51d) target(ffc2e7d) trend
clear-1k.benchmark:benchmark-table/clear/1k 16.14 (± 0.48 ms) 12.46 (± 0.48 ms) 👍
create-1k.benchmark:benchmark-table/create/1k 183.62 (± 1.32 ms) 150.36 (± 1.32 ms) 👍
update-10th-1k.benchmark:benchmark-table/update-10th/1k 145.66 (± 1.23 ms) 123.92 (± 1.23 ms) 👍

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: a5ad51d | Target commit: 0cb38b9

benchmark base(a5ad51d) target(0cb38b9) trend
clear-1k.benchmark:benchmark-table/clear/1k 16.14 (± 0.80 ms) 15.11 (± 0.80 ms) 👍
create-1k.benchmark:benchmark-table/create/1k 183.62 (± 10.66 ms) 164.38 (± 10.66 ms) 👍
update-10th-1k.benchmark:benchmark-table/update-10th/1k 145.66 (± 2.86 ms) 133.61 (± 2.86 ms) 👍

@diervo
Copy link
Contributor Author

diervo commented Feb 6, 2018

@pmdartus I'm not happy having two independent benchmarks (benchmark-table and benchmark-table-component) in the same file, because if we were to have a memory leak, or any sort of intrinsic dependency, data will be skewed.

Note that new tests don't show here yet because the diffing is against the common.

I think the recommendation would always be to have independent benchmarks in independent files.

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: a5ad51d | Target commit: d8d5b59

benchmark base(a5ad51d) target(d8d5b59) trend
clear-1k.benchmark:benchmark-table/clear/1k 16.14 (± 1.44 ms) 37.85 (± 1.44 ms) 👎

@diervo diervo merged commit 1c05721 into master Feb 6, 2018
@diervo diervo deleted the pmdartus/best-migration branch February 6, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants