feat(engine): dom patching #688

davidturissini · 2018-09-28T23:28:16Z

Details

Removing traversal membrane. Patching dom prototype methods instead.

Does this PR introduce a breaking change?

Yes
No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

Shadow methods and properties are no longer lazy loaded, which means that there are no shadow escape hatches for external libraries.

ravijayaramappa · 2018-09-28T23:45:40Z

@davidturissini @caridy Locker relies on the unwrap() api to detect nodes created by lwc. Removing traverse-membrane before W-5143776 is done will break our tests.

caridy · 2018-09-29T01:24:11Z

This is actually way simpler than I thought it will be.

What about .shadowRoot accessor for the custom elements?

pmdartus · 2018-10-01T13:15:47Z

packages/lwc-engine/src/framework/patch.ts

@@ -32,7 +34,7 @@ let TextNodeProto: object;
 // to patch text nodes generated by a template.
 export function patchTextNodeProto(text: Text) {
    if (isUndefined(TextNodeProto)) {
-        TextNodeProto = getPrototypeOf(text);
+        TextNodeProto = create(getPrototypeOf(text), NodePatchDescriptors);


What about doing this during the library initialization to avoid the branching at runtime?

If we move this to library initialization, we will be creating this object even when native shadow is supported

I'm fine with this approach.

This code should also be used in patchCommentNodeProto, maybe abstract it since it is the same for both type of nodes.

pmdartus · 2018-10-01T13:16:34Z

packages/lwc-engine/src/framework/membrane.ts

-     }
-     // traverse membrane is not that important, it goes second
-     unwrapped = getRawNode(value);
+     const unwrapped = reactiveMembrane.unwrapProxy(value);


This is beautiful!

pmdartus · 2018-10-01T13:19:34Z

packages/lwc-engine/src/faux-shadow/events.ts

@@ -40,7 +39,7 @@ const EventPatchDescriptors: PropertyDescriptorMap = {
                // event is already beyond the boundaries of our controlled shadow roots
                return currentTarget;
            }
-            return patchShadowDomTraversalMethods(currentTarget as Element);
+            return currentTarget as Element;


Let's remove the above branch since it's not needed anymore. By the way, do we even need to patch the currentTarget since the code can be simplified to only invoke the original getter.

packages/lwc-engine/src/faux-shadow/events.ts

salesforce-best-lwc-internal · 2018-10-01T21:57:48Z

Benchmark results

Base commit: 4e3ac4e | Target commit: ca0aeaf

lwc-engine-benchmark-ie11

table-append-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

table-clear-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

table-create-10k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

table-create-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

table-update-10th-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

tablecmp-append-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

tablecmp-clear-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

tablecmp-create-10k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

tablecmp-create-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

tablecmp-update-10th-1k	metric	base(`4e3ac4e`)	target(`ca0aeaf`)	trend

salesforce-best-lwc-internal · 2018-10-01T22:24:29Z

Benchmark results

Base commit: 4e3ac4e | Target commit: 572f8eb

lwc-engine-benchmark-ie11

table-append-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

table-clear-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

table-create-10k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

table-create-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

table-update-10th-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

tablecmp-append-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

tablecmp-clear-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

tablecmp-create-10k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

tablecmp-create-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

tablecmp-update-10th-1k	metric	base(`4e3ac4e`)	target(`572f8eb`)	trend

caridy · 2018-10-02T01:55:36Z

packages/lwc-engine/src/faux-shadow/custom-element.ts

@@ -31,6 +35,11 @@ const CustomElementPatchDescriptors: PropertyDescriptorMap = {
        configurable: true,
        enumerable: true,
    },
+    shadowRoot: {
+        value: getShadowRootPatchedValue,


this should be a getter instead.

caridy · 2018-10-02T01:56:00Z

packages/lwc-engine/src/faux-shadow/events.ts

@@ -33,18 +32,6 @@ const eventCurrentTargetGetter: (this: Event) => Element | null = getOwnProperty
 const GET_ROOT_NODE_CONFIG_FALSE = { composed: false };

 const EventPatchDescriptors: PropertyDescriptorMap = {
-    currentTarget: {


caridy · 2018-10-02T01:57:05Z

packages/lwc-engine/src/faux-shadow/traverse.ts

@@ -230,12 +225,6 @@ export function getFilteredChildNodes(node: Node): Element[] {
 }

 function lightDomChildNodesGetter(this: HTMLElement): Node[] {
-    if (process.env.NODE_ENV !== 'production') {


any reason for this to be removed?

restrictions was already logging a warning for childNodes, so this was redundant

caridy · 2018-10-02T01:58:34Z

packages/lwc-engine/src/framework/__tests__/api.spec.ts

@@ -181,14 +181,14 @@ describe('api', () => {
            const elm = createElement('x-foo', { is: Foo });
            document.body.appendChild(elm);
            // TODO: once we switch to shadow DOM this test will have to be adjusted
-            expect(elm.textContent).toEqual('miami');
+            expect(getHostShadowRoot(elm).querySelector('span').textContent).toEqual('miami');


why not using elm.shadowRoot.querySelector?

caridy · 2018-10-02T02:00:37Z

packages/lwc-engine/src/framework/hooks.ts

@@ -78,7 +78,6 @@ export const createCustomElmHook = (vnode: VCustomElement) => {
    }
    setNodeOwnerKey(elm, uid);
    const def = getComponentDef(ctor);
-    setElementProto(elm, def);


this can't be removed @davidturissini

This already happens in patchCustomElementProto, which is called on line 82

caridy · 2018-10-02T02:02:01Z

packages/lwc-engine/src/framework/membrane.ts


 function valueDistortion(value: any) {
-    if (process.env.NODE_ENV !== 'production') {


caridy · 2018-10-02T02:12:17Z

packages/lwc-engine/src/framework/upgrade.ts

@@ -84,7 +84,7 @@ export function createElement(sel: string, options: any = {}): HTMLElement {
    const def = getComponentDef(Ctor);
    setElementProto(element, def);
    if (isTrue(fallback)) {
-        patchCustomElementProto(element, sel, def);
+        patchCustomElement(element);


Yea, this is incorrect based on our conversation yesterday

caridy

still have few questions

pmdartus · 2018-10-02T14:40:37Z

packages/lwc-engine/src/framework/patch.ts

+            descriptors = SlotPatchDescriptors;
+            break;
+        case 'IFRAME':
+            descriptors = IframeDescriptors;


Why do we need a different descriptor for iframe? Since we don't wrap it in a Proxy, it should behave like another element right?

you're probably right! The special one was before of the proxy on the first place.

We have a customer complaining because of this, that's why I thought about it. =)

The fix here has nothing to do with traverse membrane returning a proxy. We have to wrap contentWindow because isCompatProxy does a lookup on every object. If that lookup happens on a x-origin iframe, the browser will throw. This is a guard against that code. @pmdartus @caridy

ah! bad memory! that's true, it is compat, it transforms the property accessor on iframes. In that case, we should probably extend the list of properties, maybe detecting available properties from the instance rather than a whitelist.

I'm not sure what you mean here

I'm saying that you're correct, it is because of compat. I'm also saying that the patched descriptors are static today, and they might depend on what the iframe obj is returning rather than being static.

salesforce-best-lwc-internal · 2018-10-02T23:38:02Z

Benchmark results

Base commit: 039a2af | Target commit: c94fa6c

caridy · 2018-10-03T15:51:51Z

packages/lwc-engine/src/faux-shadow/custom-element.ts

@@ -36,7 +36,7 @@ const CustomElementPatchDescriptors: PropertyDescriptorMap = {
        enumerable: true,
    },
    shadowRoot: {
-        value: getShadowRootPatchedValue,
+        get: getShadowRootPatchedValue,


if it is a getter, it should be called *Getter instead of *Value

salesforce-best-lwc-internal · 2018-10-03T19:50:28Z

Benchmark results

Base commit: 0df140a | Target commit: ed72e3b

salesforce-best-lwc-internal · 2018-10-03T20:36:10Z

Benchmark results

Base commit: 0df140a | Target commit: 2ed6513

caridy

minor changes to optimize the code a little bit more.

salesforce-best-lwc-internal · 2018-10-10T18:34:59Z

Benchmark results

Base commit: 33ad77d | Target commit: 07d5dfd

salesforce-best-lwc-internal · 2018-10-10T19:32:35Z

Benchmark results

Base commit: 33ad77d | Target commit: 2727135

caridy · 2018-10-10T19:54:43Z

packages/lwc-engine/src/faux-shadow/traverse.ts

@@ -133,6 +134,10 @@ function getFirstMatch(owner: HTMLElement, nodeList: NodeList): Element | null {
    return null;
 }

+export function shadowDomElementFromPoint(host: HTMLElement, left: number, top: number) {


missing return annotation.

caridy

let's roll!

salesforce-best-lwc-internal · 2018-10-10T20:02:13Z

Benchmark results

Base commit: 33ad77d | Target commit: 1b23ee4

salesforce-best-lwc-internal · 2018-10-10T20:07:30Z

Benchmark results

Base commit: 33ad77d | Target commit: e860436

salesforce-best-lwc-internal · 2018-10-10T20:10:07Z

Benchmark results

Base commit: 33ad77d | Target commit: 1eabfb7

* feat(engine): dom patching * fix(engine): cleanup descriptors * feat(engine): rebase * fix(engine): linting * fix(engine): pr feedback * fix(engine): lint * fix(compiler): updated snapshot testing to account for shadow dom * fix(engine): pr feedback * fix(engine): fixing restrictions on custom elements * fix(engine): exposing host (#705) * fix(engine): exposing host * fix(engine): shadow root * wip(engine): linting and type errors * fix(engine): cleaning up shadow root detection * fix(engine): removing restrictions test * fix(engine): fixing element from point methods * fix(engine): disabling some attribute integration test for now * fix(engine): linting * fix(engine): upgrade ie11 driver * fix(engine): compat test fix * fix(engine): applying elementFromPoint on document * fix(engine): linting * fix(engine): reverting unnecessary changes * fix(engine): removing skip in test * fix(engine): polyfill readmes * fix(engine): review feedback * fix(engine): integration tests for elementFromPoint * fix(engine): ie11 elementsFromPoint * fix(engine): feedback * fix(engine): ts fix

* refactor(engine): removal of is attr and forceTagName refactor(engine): removal of is attr and forceTagName fix(engine): removing integration test for forceTagName refactor(engine): snabbdom lite - phase 1 refactor(engine): adding hooks.ts refactor(engine): removing global hooks refactor(engine): PR 606 refactor(engine): splitting style and class modules into static and dynamic test(engine): ready for the final push refactor(engine): making hooks mandatory. refactor(engine): making all hooks functions refactor(engine): dynamic diff vs static diff refactor(engine): using two diff algos refactor(engine): removing htmlapi in favor of pure patching fix(engine): missing argument when determining diff algo fix(engine): adding tests for dynamic diff fix(engine): clean up fix(engine): integration test failures * refactor(engine): proto chaining * fix(engine): wrong auto import * fix(engine): correcting the proto chain * refactor(engine): implementing the base element proto chain * test(engine): adding more tests for restrictions on elements * refactor(engine): rename to BaseBridgeElement * feat(engine): dom patching (#688) * feat(engine): dom patching * fix(engine): cleanup descriptors * feat(engine): rebase * fix(engine): linting * fix(engine): pr feedback * fix(engine): lint * fix(compiler): updated snapshot testing to account for shadow dom * fix(engine): pr feedback * fix(engine): fixing restrictions on custom elements * fix(engine): exposing host (#705) * fix(engine): exposing host * fix(engine): shadow root * wip(engine): linting and type errors * fix(engine): cleaning up shadow root detection * fix(engine): removing restrictions test * fix(engine): fixing element from point methods * fix(engine): disabling some attribute integration test for now * fix(engine): linting * fix(engine): upgrade ie11 driver * fix(engine): compat test fix * fix(engine): applying elementFromPoint on document * fix(engine): linting * fix(engine): reverting unnecessary changes * fix(engine): removing skip in test * fix(engine): polyfill readmes * fix(engine): review feedback * fix(engine): integration tests for elementFromPoint * fix(engine): ie11 elementsFromPoint * fix(engine): feedback * fix(engine): ts fix * wip: yarn update * fix(engine): fixing snapshot test

refactor(engine): removal of is attr and forceTagName fix(engine): removing integration test for forceTagName fix: remove custom element transformation from CSS (#695) fix(compiler): fixing fixtures refactor(engine): snabbdom lite - phase 1 (#606) * refactor(engine): removal of is attr and forceTagName refactor(engine): removal of is attr and forceTagName fix(engine): removing integration test for forceTagName refactor(engine): snabbdom lite - phase 1 refactor(engine): adding hooks.ts refactor(engine): removing global hooks refactor(engine): PR 606 refactor(engine): splitting style and class modules into static and dynamic test(engine): ready for the final push refactor(engine): making hooks mandatory. refactor(engine): making all hooks functions refactor(engine): dynamic diff vs static diff refactor(engine): using two diff algos refactor(engine): removing htmlapi in favor of pure patching fix(engine): missing argument when determining diff algo fix(engine): adding tests for dynamic diff fix(engine): clean up fix(engine): integration test failures * refactor(engine): proto chaining * fix(engine): wrong auto import * fix(engine): correcting the proto chain * refactor(engine): implementing the base element proto chain * test(engine): adding more tests for restrictions on elements * refactor(engine): rename to BaseBridgeElement * feat(engine): dom patching (#688) * feat(engine): dom patching * fix(engine): cleanup descriptors * feat(engine): rebase * fix(engine): linting * fix(engine): pr feedback * fix(engine): lint * fix(compiler): updated snapshot testing to account for shadow dom * fix(engine): pr feedback * fix(engine): fixing restrictions on custom elements * fix(engine): exposing host (#705) * fix(engine): exposing host * fix(engine): shadow root * wip(engine): linting and type errors * fix(engine): cleaning up shadow root detection * fix(engine): removing restrictions test * fix(engine): fixing element from point methods * fix(engine): disabling some attribute integration test for now * fix(engine): linting * fix(engine): upgrade ie11 driver * fix(engine): compat test fix * fix(engine): applying elementFromPoint on document * fix(engine): linting * fix(engine): reverting unnecessary changes * fix(engine): removing skip in test * fix(engine): polyfill readmes * fix(engine): review feedback * fix(engine): integration tests for elementFromPoint * fix(engine): ie11 elementsFromPoint * fix(engine): feedback * fix(engine): ts fix * wip: yarn update * fix(engine): fixing snapshot test

* refactor(engine): removal of is attr and forceTagName * fix(engine): removing integration test for forceTagName * fix: remove custom element transformation from CSS (#695) * fix(compiler): fixing fixtures * refactor(engine): snabbdom lite - phase 1 (#606) * refactor(engine): removal of is attr and forceTagName * refactor(engine): removal of is attr and forceTagName * fix(engine): removing integration test for forceTagName * refactor(engine): snabbdom lite - phase 1 * refactor(engine): adding hooks.ts * refactor(engine): removing global hooks * refactor(engine): splitting style and class modules into static and dynamic * test(engine): ready for the final push * refactor(engine): making hooks mandatory. * refactor(engine): making all hooks functions * refactor(engine): dynamic diff vs static diff * refactor(engine): using two diff algos * refactor(engine): removing htmlapi in favor of pure patching * fix(engine): missing argument when determining diff algo * fix(engine): adding tests for dynamic diff * fix(engine): clean up * fix(engine): integration test failures * refactor(engine): proto chaining * fix(engine): wrong auto import * fix(engine): correcting the proto chain * refactor(engine): implementing the base element proto chain * test(engine): adding more tests for restrictions on elements * refactor(engine): rename to BaseBridgeElement * feat(engine): dom patching (#688) * feat(engine): dom patching * fix(engine): cleanup descriptors * feat(engine): rebase * fix(engine): linting * fix(engine): pr feedback * fix(engine): lint * fix(compiler): updated snapshot testing to account for shadow dom * fix(engine): pr feedback * fix(engine): fixing restrictions on custom elements * fix(engine): exposing host (#705) * fix(engine): exposing host * fix(engine): shadow root * wip(engine): linting and type errors * fix(engine): cleaning up shadow root detection * fix(engine): removing restrictions test * fix(engine): fixing element from point methods * fix(engine): disabling some attribute integration test for now * fix(engine): linting * fix(engine): upgrade ie11 driver * fix(engine): compat test fix * fix(engine): applying elementFromPoint on document * fix(engine): linting * fix(engine): reverting unnecessary changes * fix(engine): removing skip in test * fix(engine): polyfill readmes * fix(engine): review feedback * fix(engine): integration tests for elementFromPoint * fix(engine): ie11 elementsFromPoint * fix(engine): feedback * fix(engine): ts fix * wip: yarn update * fix(engine): fixing snapshot test wip: styles still broken wip: fix styles

* * refactor(engine): removal of is attr and forceTagName * refactor(engine): removal of is attr and forceTagName * fix(engine): removing integration test for forceTagName * fix: remove custom element transformation from CSS (#695) * fix(compiler): fixing fixtures * refactor(engine): snabbdom lite - phase 1 (#606) * refactor(engine): removal of is attr and forceTagName * refactor(engine): removal of is attr and forceTagName * fix(engine): removing integration test for forceTagName * refactor(engine): snabbdom lite - phase 1 * refactor(engine): adding hooks.ts * refactor(engine): removing global hooks * refactor(engine): splitting style and class modules into static and dynamic * test(engine): ready for the final push * refactor(engine): making hooks mandatory. * refactor(engine): making all hooks functions * refactor(engine): dynamic diff vs static diff * refactor(engine): using two diff algos * refactor(engine): removing htmlapi in favor of pure patching * fix(engine): missing argument when determining diff algo * fix(engine): adding tests for dynamic diff * fix(engine): clean up * fix(engine): integration test failures * refactor(engine): proto chaining * fix(engine): wrong auto import * fix(engine): correcting the proto chain * refactor(engine): implementing the base element proto chain * test(engine): adding more tests for restrictions on elements * refactor(engine): rename to BaseBridgeElement * feat(engine): dom patching (#688) * feat(engine): dom patching * fix(engine): cleanup descriptors * feat(engine): rebase * fix(engine): linting * fix(engine): pr feedback * fix(engine): lint * fix(compiler): updated snapshot testing to account for shadow dom * fix(engine): pr feedback * fix(engine): fixing restrictions on custom elements * fix(engine): exposing host (#705) * fix(engine): exposing host * fix(engine): shadow root * wip(engine): linting and type errors * fix(engine): cleaning up shadow root detection * fix(engine): removing restrictions test * fix(engine): fixing element from point methods * fix(engine): disabling some attribute integration test for now * fix(engine): linting * fix(engine): upgrade ie11 driver * fix(engine): compat test fix * fix(engine): applying elementFromPoint on document * fix(engine): linting * fix(engine): reverting unnecessary changes * fix(engine): removing skip in test * fix(engine): polyfill readmes * fix(engine): review feedback * fix(engine): integration tests for elementFromPoint * fix(engine): ie11 elementsFromPoint * fix(engine): feedback * fix(engine): ts fix * wip: yarn update * fix(engine): fixing snapshot test wip: styles still broken wip: fix styles * refactor(engine): preliminar work for tabindex * feat(engine): prototype over descriptors * refactor(engine): preliminar work for focus and blur patch * fix(engine): invalid import statement * refactor(engine): preliminar work for focus and blur patch * fix(engine): make shadowroot a fragment * fix(engine): make shadowroot a fragment * fix(engine): make shadowroot a fragment * fix(engine): make shadowroot a fragment * feat(engine): active element for shadow roots (#740) * feat(engine): active element for shadow roots * fix(engine): linting * fix(docs): updated readme * fix(engine): types * fix(engine): nodelist iterator * fix(engine): nodelist iterator * chore(engine): rebasing next-rebased * refactor(engine): implement delegatesFocus flag * test(engine): implement delegatesFocus flag tests * chore(engine): fixing dval mess with the history * fix: newlines on tests * feat: add some polyfill tests * fix(engine): tests * fix(engine): review for PR 747

* refactor(engine): removal of is attr and forceTagName * fix(engine): removing integration test for forceTagName * fix: remove custom element transformation from CSS (#695) * fix(compiler): fixing fixtures * refactor(engine): snabbdom lite - phase 1 (#606) * refactor(engine): removal of is attr and forceTagName * refactor(engine): removal of is attr and forceTagName * fix(engine): removing integration test for forceTagName * refactor(engine): snabbdom lite - phase 1 * refactor(engine): adding hooks.ts * refactor(engine): removing global hooks * refactor(engine): splitting style and class modules into static and dynamic * test(engine): ready for the final push * refactor(engine): making hooks mandatory. * refactor(engine): making all hooks functions * refactor(engine): dynamic diff vs static diff * refactor(engine): using two diff algos * refactor(engine): removing htmlapi in favor of pure patching * fix(engine): missing argument when determining diff algo * fix(engine): adding tests for dynamic diff * fix(engine): clean up * fix(engine): integration test failures * refactor(engine): proto chaining * fix(engine): wrong auto import * fix(engine): correcting the proto chain * refactor(engine): implementing the base element proto chain * test(engine): adding more tests for restrictions on elements * refactor(engine): rename to BaseBridgeElement * feat(engine): dom patching (#688) * feat(engine): dom patching * fix(engine): cleanup descriptors * feat(engine): rebase * fix(engine): linting * fix(engine): pr feedback * fix(engine): lint * fix(compiler): updated snapshot testing to account for shadow dom * fix(engine): pr feedback * fix(engine): fixing restrictions on custom elements * fix(engine): exposing host (#705) * fix(engine): exposing host * fix(engine): shadow root * wip(engine): linting and type errors * fix(engine): cleaning up shadow root detection * fix(engine): removing restrictions test * fix(engine): fixing element from point methods * fix(engine): disabling some attribute integration test for now * fix(engine): linting * fix(engine): upgrade ie11 driver * fix(engine): compat test fix * fix(engine): applying elementFromPoint on document * fix(engine): linting * fix(engine): reverting unnecessary changes * fix(engine): removing skip in test * fix(engine): polyfill readmes * fix(engine): review feedback * fix(engine): integration tests for elementFromPoint * fix(engine): ie11 elementsFromPoint * fix(engine): feedback * fix(engine): ts fix * wip: yarn update * fix(engine): fixing snapshot test

davidturissini requested review from caridy and ekashida September 28, 2018 23:28

pmdartus reviewed Oct 1, 2018

View reviewed changes

davidturissini added 3 commits October 1, 2018 10:49

feat(engine): dom patching

f41a2f7

fix(engine): cleanup descriptors

e25eb65

feat(engine): rebase

6abb9e3

davidturissini force-pushed the dturissini/dom-prototype-inserting branch from 341434b to 6abb9e3 Compare October 1, 2018 21:47

fix(engine): linting

ca0aeaf

davidturissini added 2 commits October 1, 2018 14:59

fix(engine): pr feedback

d20b0e2

fix(engine): lint

572f8eb

caridy reviewed Oct 2, 2018

View reviewed changes

pmdartus reviewed Oct 2, 2018

View reviewed changes

fix(compiler): updated snapshot testing to account for shadow dom

c94fa6c

caridy reviewed Oct 3, 2018

View reviewed changes

fix(engine): pr feedback

ed72e3b

fix(engine): fixing restrictions on custom elements

2ed6513

caridy suggested changes Oct 10, 2018

View reviewed changes

fix(engine): review feedback

07d5dfd

fix(engine): integration tests for elementFromPoint

2727135

caridy reviewed Oct 10, 2018

View reviewed changes

fix(engine): ie11 elementsFromPoint

1b23ee4

caridy approved these changes Oct 10, 2018

View reviewed changes

davidturissini added 2 commits October 10, 2018 13:03

fix(engine): feedback

e860436

fix(engine): ts fix

1eabfb7

davidturissini merged commit a201127 into caridy/proto-chaining-refactor Oct 11, 2018

davidturissini deleted the dturissini/dom-prototype-inserting branch October 11, 2018 18:30

diervo mentioned this pull request Oct 13, 2018

feat: next rebased #734

Merged


		function valueDistortion(value: any) {
		if (process.env.NODE_ENV !== 'production') {

feat(engine): dom patching #688

feat(engine): dom patching #688

Conversation

davidturissini commented Sep 28, 2018

Details

Does this PR introduce a breaking change?

ravijayaramappa commented Sep 28, 2018 • edited by caridy Loading

caridy commented Sep 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salesforce-best-lwc-internal bot commented Oct 1, 2018

Benchmark results

lwc-engine-benchmark-ie11

salesforce-best-lwc-internal bot commented Oct 1, 2018

Benchmark results

lwc-engine-benchmark-ie11

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caridy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salesforce-best-lwc-internal bot commented Oct 2, 2018

Benchmark results

Choose a reason for hiding this comment

salesforce-best-lwc-internal bot commented Oct 3, 2018

Benchmark results

salesforce-best-lwc-internal bot commented Oct 3, 2018

Benchmark results

caridy left a comment

Choose a reason for hiding this comment

salesforce-best-lwc-internal bot commented Oct 10, 2018

Benchmark results

salesforce-best-lwc-internal bot commented Oct 10, 2018

Benchmark results

Choose a reason for hiding this comment

caridy left a comment

Choose a reason for hiding this comment

salesforce-best-lwc-internal bot commented Oct 10, 2018

Benchmark results

salesforce-best-lwc-internal bot commented Oct 10, 2018

Benchmark results

salesforce-best-lwc-internal bot commented Oct 10, 2018

Benchmark results

ravijayaramappa commented Sep 28, 2018 •

edited by caridy

Loading