Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better svg whitelisting (from domPurify) #728

Merged
merged 3 commits into from
Oct 11, 2018
Merged

fix: better svg whitelisting (from domPurify) #728

merged 3 commits into from
Oct 11, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Oct 11, 2018

Details

ISVs reported issues with <image tag withing SVGs that should be whitelisted.
Doing a second pass in our whitelisting.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: f9ffc5c | Target commit: d36b53b

lwc-engine-benchmark

table-append-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table/append/1k duration 152.20 (±5.65 ms) 157.00 (±7.25 ms) +4.8ms (3.2%) 👎
table-clear-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table/clear/1k duration 11.85 (±0.95 ms) 12.40 (±0.75 ms) +0.5ms (4.6%) 👌
table-create-10k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table/create/10k duration 877.20 (±6.05 ms) 876.10 (±7.35 ms) -1.1ms (0.1%) 👌
table-create-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table/create/1k duration 108.15 (±1.90 ms) 110.15 (±2.35 ms) +2.0ms (1.8%) 👎
table-update-10th-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table/update-10th/1k duration 84.65 (±1.85 ms) 95.90 (±3.00 ms) +11.3ms (13.3%) 👎
tablecmp-append-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-component/append/1k duration 213.40 (±13.75 ms) 229.40 (±9.35 ms) +16.0ms (7.5%) 👎
tablecmp-clear-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-component/clear/1k duration 19.20 (±1.35 ms) 19.30 (±2.30 ms) +0.1ms (0.5%) 👌
tablecmp-create-10k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-component/create/10k duration 1575.25 (±9.05 ms) 1557.15 (±12.05 ms) -18.1ms (1.1%) 👍
tablecmp-create-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-component/create/1k duration 180.25 (±5.40 ms) 179.70 (±7.40 ms) -0.6ms (0.3%) 👌
tablecmp-update-10th-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-component/update-10th/1k duration 82.25 (±4.70 ms) 81.40 (±5.10 ms) -0.8ms (1.0%) 👌
wc-append-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-wc/append/1k duration 274.25 (±9.15 ms) 265.25 (±15.50 ms) -9.0ms (3.3%) 👍
wc-clear-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-wc/clear/1k duration 28.60 (±2.90 ms) 27.55 (±2.40 ms) -1.1ms (3.7%) 👌
wc-create-10k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-wc/create/10k duration 2049.50 (±15.20 ms) 2043.25 (±14.30 ms) -6.3ms (0.3%) 👌
wc-create-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-wc/create/1k duration 218.90 (±4.15 ms) 226.10 (±3.80 ms) +7.2ms (3.3%) 👎
wc-update-10th-1k metric base(f9ffc5c) target(d36b53b) trend
benchmark-table-wc/update-10th/1k duration 82.60 (±5.00 ms) 83.35 (±6.15 ms) +0.8ms (0.9%) 👌

@diervo diervo merged commit 92a1b5e into master Oct 11, 2018
@diervo diervo deleted the dval/svgFixes branch October 11, 2018 18:23
@kevinv11n
Copy link
Contributor

@jfparadis @ravijayaramappa can you please review to confirm no concern from locker?

@diervo
Copy link
Contributor Author

diervo commented Oct 11, 2018

@kevinv11n I been talking to the locker team about this (especifically Dejan), and I copy this from their whitelisted package:

https://[enterprise-git]/lockerservice/lockerservice-core/blob/master/packages/locker-sanitize/src/config/svg.js

We are discussing how to integrate that package further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants