Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TS defs for engine and wire #835

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix: TS defs for engine and wire #835

merged 1 commit into from
Nov 14, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Nov 14, 2018

Details

Augmentation of #829

@diervo diervo merged commit 3217ce9 into master Nov 14, 2018
@diervo diervo deleted the dval/updateDefs branch November 14, 2018 05:00
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: d2cd35f | Target commit: 5f0147c

lwc-engine-benchmark

table-append-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table/append/1k duration 154.30 (±5.10 ms) 154.20 (±5.30 ms) -0.1ms (0.1%) 👌
table-clear-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table/clear/1k duration 6.50 (±0.35 ms) 6.40 (±0.40 ms) -0.1ms (1.5%) 👌
table-create-10k metric base(d2cd35f) target(5f0147c) trend
benchmark-table/create/10k duration 937.25 (±6.05 ms) 939.75 (±6.15 ms) +2.5ms (0.3%) 👌
table-create-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table/create/1k duration 120.15 (±3.00 ms) 118.00 (±2.45 ms) -2.2ms (1.8%) 👍
table-update-10th-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table/update-10th/1k duration 79.25 (±3.70 ms) 79.40 (±2.65 ms) +0.2ms (0.2%) 👌
tablecmp-append-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-component/append/1k duration 265.55 (±7.65 ms) 261.60 (±6.25 ms) -3.9ms (1.5%) 👍
tablecmp-clear-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-component/clear/1k duration 12.40 (±2.15 ms) 12.90 (±1.50 ms) +0.5ms (4.0%) 👌
tablecmp-create-10k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-component/create/10k duration 1829.15 (±16.60 ms) 1812.85 (±14.70 ms) -16.3ms (0.9%) 👍
tablecmp-create-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-component/create/1k duration 211.75 (±6.00 ms) 215.30 (±5.65 ms) +3.6ms (1.7%) 👎
tablecmp-update-10th-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-component/update-10th/1k duration 72.55 (±6.30 ms) 71.50 (±6.75 ms) -1.1ms (1.4%) 👌
wc-append-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-wc/append/1k duration 262.80 (±13.85 ms) 255.70 (±18.65 ms) -7.1ms (2.7%) 👌
wc-clear-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-wc/clear/1k duration 24.25 (±2.55 ms) 23.45 (±2.25 ms) -0.8ms (3.3%) 👌
wc-create-10k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-wc/create/10k duration 1926.65 (±49.30 ms) 2016.70 (±57.30 ms) +90.0ms (4.7%) 👎
wc-create-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-wc/create/1k duration 235.00 (±6.05 ms) 236.20 (±5.25 ms) +1.2ms (0.5%) 👌
wc-update-10th-1k metric base(d2cd35f) target(5f0147c) trend
benchmark-table-wc/update-10th/1k duration 77.90 (±8.50 ms) 74.45 (±6.15 ms) -3.5ms (4.4%) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants