Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors package as hard dep in jest-transformer #884

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

trevor-bliss
Copy link
Contributor

@trevor-bliss trevor-bliss commented Dec 12, 2018

Details

@lwc/errors is required for @lwc/jest-transformer to properly function so move it from a peer to a hard dependency. Will clear up warnings consumers see when building.

Fixes #868

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 1bce3c7 | Target commit: 3a95664

lwc-engine-benchmark

table-append-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/append/1k duration 148.30 (±3.45 ms) 151.95 (±4.45 ms) +3.6ms (2.5%) 👎
table-clear-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/clear/1k duration 6.10 (±0.40 ms) 6.00 (±0.20 ms) -0.1ms (1.6%) 👌
table-create-10k metric base(1bce3c7) target(3a95664) trend
benchmark-table/create/10k duration 877.00 (±7.00 ms) 870.25 (±7.95 ms) -6.8ms (0.8%) 👍
table-create-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/create/1k duration 117.30 (±3.70 ms) 117.60 (±2.95 ms) +0.3ms (0.3%) 👌
table-update-10th-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/update-10th/1k duration 76.75 (±2.05 ms) 76.35 (±1.60 ms) -0.4ms (0.5%) 👌
tablecmp-append-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/append/1k duration 257.05 (±8.45 ms) 260.70 (±5.65 ms) +3.7ms (1.4%) 👎
tablecmp-clear-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/clear/1k duration 11.50 (±1.55 ms) 12.50 (±1.90 ms) +1.0ms (8.7%) 👌
tablecmp-create-10k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/create/10k duration 1755.20 (±14.30 ms) 1752.95 (±8.60 ms) -2.2ms (0.1%) 👌
tablecmp-create-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/create/1k duration 207.95 (±4.95 ms) 212.25 (±5.05 ms) +4.3ms (2.1%) 👎
tablecmp-update-10th-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/update-10th/1k duration 72.15 (±5.45 ms) 72.80 (±4.80 ms) +0.6ms (0.9%) 👌
wc-append-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/append/1k duration 255.80 (±6.85 ms) 260.25 (±9.50 ms) +4.4ms (1.7%) 👌
wc-clear-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/clear/1k duration 23.15 (±3.05 ms) 23.60 (±2.50 ms) +0.5ms (1.9%) 👌
wc-create-10k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/create/10k duration 1955.80 (±12.55 ms) 1964.65 (±15.50 ms) +8.8ms (0.5%) 👎
wc-create-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/create/1k duration 225.95 (±5.50 ms) 227.30 (±5.45 ms) +1.4ms (0.6%) 👌
wc-update-10th-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/update-10th/1k duration 73.80 (±5.65 ms) 72.20 (±5.55 ms) -1.6ms (2.2%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 1bce3c7 | Target commit: 3a95664

lwc-engine-benchmark

table-append-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/append/1k duration 148.30 (±3.45 ms) 150.00 (±4.10 ms) +1.7ms (1.1%) 👌
table-clear-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/clear/1k duration 6.10 (±0.40 ms) 5.95 (±0.35 ms) -0.1ms (2.5%) 👌
table-create-10k metric base(1bce3c7) target(3a95664) trend
benchmark-table/create/10k duration 877.00 (±7.00 ms) 885.50 (±6.90 ms) +8.5ms (1.0%) 👎
table-create-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/create/1k duration 117.30 (±3.70 ms) 119.15 (±3.10 ms) +1.9ms (1.6%) 👎
table-update-10th-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table/update-10th/1k duration 76.75 (±2.05 ms) 77.45 (±3.95 ms) +0.7ms (0.9%) 👌
tablecmp-append-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/append/1k duration 257.05 (±8.45 ms) 254.45 (±5.95 ms) -2.6ms (1.0%) 👌
tablecmp-clear-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/clear/1k duration 11.50 (±1.55 ms) 11.50 (±1.75 ms) 0.0ms (0.0%) 👌
tablecmp-create-10k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/create/10k duration 1755.20 (±14.30 ms) 1807.00 (±13.30 ms) +51.8ms (3.0%) 👎
tablecmp-create-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/create/1k duration 207.95 (±4.95 ms) 212.90 (±6.50 ms) +4.9ms (2.4%) 👎
tablecmp-update-10th-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-component/update-10th/1k duration 72.15 (±5.45 ms) 71.50 (±5.15 ms) -0.7ms (0.9%) 👌
wc-append-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/append/1k duration 255.80 (±6.85 ms) 255.80 (±6.15 ms) 0.0ms (0.0%) 👌
wc-clear-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/clear/1k duration 23.15 (±3.05 ms) 21.25 (±1.90 ms) -1.9ms (8.2%) 👍
wc-create-10k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/create/10k duration 1955.80 (±12.55 ms) 1942.20 (±12.70 ms) -13.6ms (0.7%) 👍
wc-create-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/create/1k duration 225.95 (±5.50 ms) 225.90 (±3.30 ms) -0.0ms (0.0%) 👌
wc-update-10th-1k metric base(1bce3c7) target(3a95664) trend
benchmark-table-wc/update-10th/1k duration 73.80 (±5.65 ms) 75.45 (±4.75 ms) +1.7ms (2.2%) 👌

@trevor-bliss trevor-bliss merged commit 9d8717c into master Dec 12, 2018
@trevor-bliss trevor-bliss deleted the tbliss/errors-as-hard-dep branch December 12, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants