Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): issue #989 enumerable in shadowRoot #998

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jan 22, 2019

bugfix: #989

@caridy caridy requested a review from pmdartus January 22, 2019 21:04
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 8c5076e | Target commit: 7bb18f0

lwc-engine-benchmark

table-append-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/append/1k duration 151.05 (±4.90 ms) 161.00 (±5.60 ms) +9.9ms (6.6%) 👎
table-clear-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/clear/1k duration 5.80 (±0.30 ms) 7.10 (±0.40 ms) +1.3ms (22.4%) 👎
table-create-10k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/create/10k duration 872.30 (±6.65 ms) 898.10 (±6.60 ms) +25.8ms (3.0%) 👎
table-create-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/create/1k duration 116.40 (±2.50 ms) 121.80 (±3.55 ms) +5.4ms (4.6%) 👎
table-update-10th-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/update-10th/1k duration 74.80 (±3.65 ms) 76.20 (±2.50 ms) +1.4ms (1.9%) 👌
tablecmp-append-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/append/1k duration 223.30 (±14.45 ms) 252.60 (±4.00 ms) +29.3ms (13.1%) 👎
tablecmp-clear-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/clear/1k duration 11.60 (±1.75 ms) 12.30 (±1.70 ms) +0.7ms (6.0%) 👌
tablecmp-create-10k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/create/10k duration 1770.85 (±12.90 ms) 1794.35 (±11.70 ms) +23.5ms (1.3%) 👎
tablecmp-create-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/create/1k duration 208.65 (±5.35 ms) 213.20 (±6.10 ms) +4.6ms (2.2%) 👎
tablecmp-update-10th-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/update-10th/1k duration 67.55 (±4.65 ms) 68.45 (±4.35 ms) +0.9ms (1.3%) 👌
wc-append-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/append/1k duration 257.60 (±6.30 ms) 258.40 (±5.80 ms) +0.8ms (0.3%) 👌
wc-clear-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/clear/1k duration 23.10 (±2.10 ms) 24.00 (±2.40 ms) +0.9ms (3.9%) 👌
wc-create-10k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/create/10k duration 1970.95 (±11.15 ms) 1970.95 (±10.95 ms) 0.0ms (0.0%) 👌
wc-create-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/create/1k duration 219.95 (±4.55 ms) 222.05 (±4.40 ms) +2.1ms (1.0%) 👌
wc-update-10th-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/update-10th/1k duration 65.35 (±4.35 ms) 74.55 (±5.20 ms) +9.2ms (14.1%) 👎

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 8c5076e | Target commit: 7bb18f0

lwc-engine-benchmark

table-append-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/append/1k duration 151.05 (±4.90 ms) 147.20 (±5.35 ms) -3.9ms (2.5%) 👌
table-clear-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/clear/1k duration 5.80 (±0.30 ms) 5.80 (±0.40 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/create/10k duration 872.30 (±6.65 ms) 865.00 (±4.45 ms) -7.3ms (0.8%) 👍
table-create-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/create/1k duration 116.40 (±2.50 ms) 116.50 (±3.10 ms) +0.1ms (0.1%) 👌
table-update-10th-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table/update-10th/1k duration 74.80 (±3.65 ms) 73.95 (±1.95 ms) -0.8ms (1.1%) 👌
tablecmp-append-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/append/1k duration 223.30 (±14.45 ms) 223.85 (±15.60 ms) +0.5ms (0.2%) 👌
tablecmp-clear-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/clear/1k duration 11.60 (±1.75 ms) 11.35 (±1.55 ms) -0.2ms (2.2%) 👌
tablecmp-create-10k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/create/10k duration 1770.85 (±12.90 ms) 1737.30 (±12.20 ms) -33.5ms (1.9%) 👍
tablecmp-create-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/create/1k duration 208.65 (±5.35 ms) 210.50 (±6.00 ms) +1.9ms (0.9%) 👌
tablecmp-update-10th-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-component/update-10th/1k duration 67.55 (±4.65 ms) 69.15 (±4.55 ms) +1.6ms (2.4%) 👌
wc-append-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/append/1k duration 257.60 (±6.30 ms) 255.90 (±5.00 ms) -1.7ms (0.7%) 👌
wc-clear-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/clear/1k duration 23.10 (±2.10 ms) 20.15 (±2.05 ms) -3.0ms (12.8%) 👍
wc-create-10k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/create/10k duration 1970.95 (±11.15 ms) 1981.30 (±12.05 ms) +10.4ms (0.5%) 👎
wc-create-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/create/1k duration 219.95 (±4.55 ms) 222.95 (±5.35 ms) +3.0ms (1.4%) 👎
wc-update-10th-1k metric base(8c5076e) target(7bb18f0) trend
benchmark-table-wc/update-10th/1k duration 65.35 (±4.35 ms) 67.55 (±3.90 ms) +2.2ms (3.4%) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants