Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auth with url when TESTKIT_HUB_USERNAME is passed #345

Merged
merged 3 commits into from
Nov 29, 2022
Merged

fix: auth with url when TESTKIT_HUB_USERNAME is passed #345

merged 3 commits into from
Nov 29, 2022

Conversation

WillieRuemmele
Copy link
Contributor

@WillieRuemmele WillieRuemmele commented Nov 23, 2022 •
edited
Loading

@W-12129945@

uses TESTKIT_HUB_USERNAME to get the auth url and auth with that

@mshanemc
Copy link
Contributor

QA notes:

ran the plugin-user NUTs on an auth-url.
✅ Worked fine
✅ expected errors for a bad username
✅ expected errors for an empty username

@mshanemc mshanemc merged commit cb58b2b into main Nov 29, 2022
@mshanemc mshanemc deleted the wr/hubUsername branch November 29, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillieRuemmele @mshanemc