fix: ignore errors from when sessionDir can't be deleted #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes testkit session.clean fails (because file activity is still happening). Some of the nuts have try/catch around that, which we can now remove.
There's a nodejs bug about lstat quirks on windows. nodejs/node#45253
I've been running this on windows to try to solve
https://github.com/forcedotcom/sfdx-core/actions/runs/5477437565/jobs/9976954011#step:13:202
I've got it isolated, and using the debugger/debug console, it'll hang on
fs.rmwhen the retry options are present, even if the timeout/max are set to a really low limit. An EPERM just causes it to get stuck.It's possible that on windows, logger is leaving the log file open until the worker_thread finisihes, which causes lstat problems (EPERM) during the rm retries. We'll test that potential issue separately.
the goal of this PR is to decouple testkit's cleanup issues from "did my NUT pass/fail" to reduce flap.