Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go modules compatibility #19

Open
horgh opened this issue Jun 7, 2019 · 3 comments
Open

Go modules compatibility #19

horgh opened this issue Jun 7, 2019 · 3 comments

Comments

@horgh
Copy link

horgh commented Jun 7, 2019

Hi!

Would it be possible to update this package to be compatible with Go modules?

I think when I try to import it right now it's looking for a v5 module and failing, based on my understanding of https://github.com/golang/go/wiki/Modules#semantic-import-versioning, because of the v5 in the import path:

$ go build
go: finding github.com/salsita/go-pivotaltracker/v5/pivotal latest
go: finding github.com/salsita/go-pivotaltracker/v5 latest
go: downloading github.com/salsita/go-pivotaltracker/v5 v5.0.0-20181227212238-6d1834bca959
build github.maxmind.com/maxmind/mm_website.git/go/check-go-version: cannot find module for path github.com/salsita/go-pivotaltracker/v5/pivotal

I'm not sure the best way to address this unfortunately.

Thank you!

@horgh
Copy link
Author

horgh commented Jun 7, 2019

Oh, using the gopkg.in import path works it seems!

@horgh horgh closed this as completed Jun 8, 2019
@horgh horgh reopened this Jun 28, 2019
@horgh
Copy link
Author

horgh commented Jun 28, 2019

This is an issue when trying to work with a fork of the repo too, which is useful when working on improvements!

@tchap
Copy link
Contributor

tchap commented Jul 12, 2019

I think that we could do https://github.com/salsita/go-pivotaltracker/compare/enable-go-modules?expand=1 and tag the repo as v3.0.0, I don't see any other way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants