Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ability to install Docker deb package using apt-get repo on Debian/Ubuntu Linux #294

Open
MurzNN opened this issue Jun 18, 2021 · 3 comments

Comments

@MurzNN
Copy link

MurzNN commented Jun 18, 2021

Is your feature request related to a problem?

At now formula installs Docker via direct downloading the binary from web. But for many users more convenient way is to install using system repositories, to receive automatic updates together with all other system packages.

Describe the solution you'd like

Will be good to add an option into formula, that installs docker via apt-get from repositories on Debian/Ubuntu-based systems, and maybe similar way for other Linux families.

@myii
Copy link
Member

myii commented Jun 18, 2021

@MurzNN You should be able to install from package (including specific repo-based installations) by looking at the pillars set up in the ways used by the tests:

@MurzNN
Copy link
Author

MurzNN commented Jun 19, 2021

Thanks! As I understand, main option is use_upstream: repo to switch from direct downloading to repo (apt for debian-based), right? I tried to find this option before creating issue in https://github.com/saltstack-formulas/docker-formula/blob/master/pillar.example but it is missing, maybe add it to that file too (with commenting what it means)?

P.S. Also I see difference between docker.pkg.config in https://github.com/saltstack-formulas/docker-formula/blob/master/test/salt/pillar/repo.sls and docker.pkg.environ in https://github.com/saltstack-formulas/docker-formula/blob/master/pillar.example - which is right?

@myii
Copy link
Member

myii commented Jun 19, 2021

Thanks! As I understand, main option is use_upstream: repo to switch from direct downloading to repo (apt for debian-based), right? I tried to find this option before creating issue in https://github.com/saltstack-formulas/docker-formula/blob/master/pillar.example but it is missing, maybe add it to that file too (with commenting what it means)?

P.S. Also I see difference between docker.pkg.config in https://github.com/saltstack-formulas/docker-formula/blob/master/test/salt/pillar/repo.sls and docker.pkg.environ in https://github.com/saltstack-formulas/docker-formula/blob/master/pillar.example - which is right?

That's good feedback, @MurzNN. Perhaps @noelmcloughlin will be able to address it, including the question you ask at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants