Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Network specification should be a dict not list #326

Open
olipinski opened this issue Mar 27, 2023 · 0 comments
Open

[BUG] Network specification should be a dict not list #326

olipinski opened this issue Mar 27, 2023 · 0 comments
Labels

Comments

@olipinski
Copy link

olipinski commented Mar 27, 2023

Your setup

Formula commit hash / release tag

latest

Versions reports (master & minion)

3005.1

Pillar / config used

pillar a:

docker:
  networks:
    - a

pillar b:

docker:
  networks:
    - b

Bug details

Describe the bug

Currently, due to the ways that pillars are merged (saltstack/salt#28394, saltstack-formulas/zabbix-formula#60), one of the networks will get overwritten, resulting in the config passed to the formula as

docker:
  networks:
    - a

Instead of

docker:
  networks:
    - a
    - b

Steps to reproduce the bug

Attempt to apply the formula with pillars as above.

Expected behaviour

Passed config is:

docker:
  networks:
    - a
    - b

Attempts to fix the bug

Bug can be fixed easily by using dicts instead. Defining the pillars as:

pillar a:

docker:
  networks:
    a:

pillar b:

docker:
  networks:
    b:

gives the correct config passed with

docker:
  networks:
    a:
    b:
@olipinski olipinski added the bug label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant