chore(version): use tomcat9 on ubuntu/debian

[noelmcloughlin]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

Primary type

• [build] Changes related to the build system
• [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ci] Changes to the continuous integration configuration
• [feat] A new feature
• [fix] A bug fix
• [perf] A code change that improves performance
• [refactor] A code change that neither fixes a bug nor adds a feature
• [revert] A change used to revert a previous commit
• [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [docs] Documentation changes
• [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#97

Describe the changes you're proposing

Since #97 was never fixed the best solution is to use Tomcat9 on the Debian family and close #97

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

          ID: tomcat package installed and service running
    Function: service.running
        Name: tomcat9
      Result: True
     Comment: Service tomcat9 is already enabled, and is running
     Started: 21:52:26.118312
    Duration: 1428.815 ms
     Changes:
              ----------
              tomcat9:
                  True

Summary for local
-------------
Succeeded: 11 (changed=6)
Failed:     0
-------------
Total states run:     11
Total run time:   26.494 s
vagrant@ubuntu1804:~$ systemctl status tomcat9
● tomcat9.service - Apache Tomcat 9 Web Application Server
   Loaded: loaded (/lib/systemd/system/tomcat9.service; enabled; vendor preset: enabled)
   Active: active (running) since Thu 2020-11-26 21:52:27 UTC; 12s ago
     Docs: https://tomcat.apache.org/tomcat-9.0-doc/index.html
  Process: 12505 ExecStartPre=/usr/libexec/tomcat9/tomcat-update-policy.sh (code=exited, status=0/SUCCESS)
 Main PID: 12518 (java)
    Tasks: 36 (limit: 4915)
   CGroup: /system.slice/tomcat9.service
           └─12518 /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Djava.util.logging.config.file=/var/lib/tomcat9/conf/logging.properties -Djava.util.logging.ma

Nov 26 21:52:30 ubuntu1804.localdomain tomcat9[12518]: Deployment of deployment descriptor [/etc/tomcat9/Catalina/localhost/manager.xml] has finished in [1,17
Nov 26 21:52:30 ubuntu1804.localdomain tomcat9[12518]: Deploying deployment descriptor [/etc/tomcat9/Catalina/localhost/host-manager.xml]
Nov 26 21:52:30 ubuntu1804.localdomain tomcat9[12518]: The path attribute with value [/host-manager] in deployment descriptor [/etc/tomcat9/Catalina/localhost
Nov 26 21:52:30 ubuntu1804.localdomain tomcat9[12518]: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a
Nov 26 21:52:30 ubuntu1804.localdomain tomcat9[12518]: Deployment of deployment descriptor [/etc/tomcat9/Catalina/localhost/host-manager.xml] has finished in
Nov 26 21:52:30 ubuntu1804.localdomain tomcat9[12518]: Deploying web application directory [/var/lib/tomcat9/webapps/ROOT]
Nov 26 21:52:31 ubuntu1804.localdomain tomcat9[12518]: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a
Nov 26 21:52:31 ubuntu1804.localdomain tomcat9[12518]: Deployment of web application directory [/var/lib/tomcat9/webapps/ROOT] has finished in [567] ms
Nov 26 21:52:31 ubuntu1804.localdomain tomcat9[12518]: Starting ProtocolHandler ["http-nio-8080"]
Nov 26 21:52:31 ubuntu1804.localdomain tomcat9[12518]: Server startup in [2,362] milliseconds

[noelmcloughlin]

Merging based on approval in #97

[saltstack-formulas-travis]

🎉 This PR is included in version 0.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[myii]

A gentle reminder here. This caused a regression for Debian-9, since the values from osfamilymap.yaml were being used for it (an empty dict in osfingermap.yaml):

tomcat-formula/tomcat/osfingermap.yaml

Line 18 in fce35a5

Debian-9: {}

This has been fixed in #120. Just have to be careful when modifying .yaml files "higher up the tree", that it doesn't cause problems "lower down".

In fact, this would have been caught by the verification tests but Travis CI was on the blink at the time of this PR being submitted.

[noelmcloughlin]

I opened #97 two years ago hit the same issue again in Nov 2020 and proposed a fix on #97 which chrisco484 aproved of. (#97 (comment)). Ubuntu is a high priority.
But I take your point and will try to be careful.