Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More data in the auth events #43394

Closed
mirceaulinic opened this issue Sep 7, 2017 · 1 comment
Closed

More data in the auth events #43394

mirceaulinic opened this issue Sep 7, 2017 · 1 comment
Labels
Duplicate Duplicate of another issue or PR - will be closed
Milestone

Comments

@mirceaulinic
Copy link
Contributor

Description of Issue/Question

At the time being, the authentication event has the following details:

salt/auth	{
    "_stamp": "2017-09-07T19:19:45.523301",
    "act": "pend",
    "id": "vmx1",
    "pub": "-----BEGIN PUBLIC KEY-----... snip ...-----END PUBLIC KEY-----",
    "result": true
}

In order to be able to correctly and safely determine if the minion you are going to accept automatically is really the one you want, there it would be needed at least the IP address where the minion runs. I can see several other interesting details that might help: hostname, IPv6 and so on.

I am opening this as a feature I'll be happy to implement, but it might take a while till I have the time to actually implement it. If there's anyone that could get to it earlier, please feel free to solve it.

Meanwhile, there's the following conversation I would like to have: who inserts the IP address into the payload? If the minion sends it, that cannot be entirely safe (i.e., it can set any address it wants); if the master inserts it, when using the ZMQ as the transport, IIRC, you can't determine who sent you the message.

I am looking forward to hearing your thoughts about that!
Thanks,
-Mircea

@gtmanfred
Copy link
Contributor

This would be great to have.

But this is a duplicate of #37712

Thanks!
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Duplicate of another issue or PR - will be closed
Projects
None yet
Development

No branches or pull requests

2 participants