Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh git_pillar on master start #56356

Closed
sathieu opened this issue Mar 11, 2020 · 3 comments · Fixed by #56316
Closed

Refresh git_pillar on master start #56356

sathieu opened this issue Mar 11, 2020 · 3 comments · Fixed by #56316
Assignees
@garethgreenaway
Labels
Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al severity-low 4th level, cosemtic problems, work around exists
Milestone
Magnesium

Comments

@sathieu
Copy link
Contributor

sathieu commented Mar 11, 2020

Description of Issue

With PR #53621, it is possible to reduce the frequency of git_pillar updates.

However, git_pillar is not updated on server start, and one need to wait for git_pillar_update_interval to have the first run.

Setup

Master config:

git_pillar_update_interval: 604800 # 1 week

Steps to Reproduce Issue

  • Add a new repo in the git pillar configuration.
  • Restart the master

Expected behavior:

  • The new repo is available directly

Actual behavior:

  • The new repo is available after 1 week 😞

Versions Report

v3000
@sathieu
Copy link
Contributor Author

sathieu commented Mar 11, 2020

Fixed by #56316.

@sathieu sathieu mentioned this issue Mar 11, 2020
Merged
@Ch3LL
Copy link
Contributor

Ch3LL commented Mar 12, 2020

thanks!

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists P4 Priority 4 labels Mar 12, 2020
@Ch3LL Ch3LL added this to the Approved milestone Mar 12, 2020
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label May 29, 2020
@sathieu sathieu mentioned this issue May 30, 2020
Closed
@sagetherage sagetherage removed the P4 Priority 4 label Jun 3, 2020
@pguinardco
Copy link

Any ETA on getting this merged in?

@sagetherage sagetherage modified the milestones: Approved, Magnesium Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
Magnesium
Development

Successfully merging a pull request may close this issue.

On start, update git_pillar on second loop sathieu/salt
5 participants
@garethgreenaway @sathieu @pguinardco @Ch3LL @sagetherage