loader: Add __opts__ to pack if not already present
#63013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
__opts__dunder dictionary to the loader'spackif not already present, which makes it accessible via thesalt.loader.context.NamedLoaderContextclass.What issues does this PR fix or reference?
See #62932 (comment) for context.
Previous Behavior
Accessing
__opts__viasalt.loader.context.NamedLoaderContextraised aKeyError: '__opts__'exception.New Behavior
Accessing
__opts__viasalt.loader.context.NamedLoaderContextis now possible, and returns (a proxy for) the options dict that is passed to theLazyLoaderconstructor.Merge requirements satisfied?
Commits signed with GPG?
no