Enhance openscap module: add "xccdf_eval" function #63416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaksh
force-pushed
the
master-enhance-openscap-module
branch
from
649cf25
to
03ad012
Compare
Ch3LL
suggested changes
Jan 9, 2023
|
Hey @Ch3LL, thanks for the review - all requested changes are done now. |
Ch3LL
suggested changes
Jan 12, 2023
s0undt3ch
suggested changes
Jan 19, 2023
|
@s0undt3ch thanks for the suggestions - all requested changes done now |
s0undt3ch
previously approved these changes
Jan 23, 2023
|
Thank You @meaksh! |
agraul
reviewed
Jan 23, 2023
|
@Ch3LL I think this should be now ready :) |
|
@Ch3LL @s0undt3ch it seems this one PR got lost. It is still waiting for a review. TIA! |
s0undt3ch
previously approved these changes
Jun 28, 2023
Ch3LL
previously approved these changes
Jun 28, 2023
|
@Ch3LL I've fixed the pre-commit issues. This should be now ready. Thanks! |
meaksh
force-pushed
the
master-enhance-openscap-module
branch
from
7ee35b5
to
d21fd03
Compare
Ch3LL
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhance the functionality of
openscapmodule: introduces a new function namedxccdf_eval.This function, allows to pass more parameters than the
xccdffunction, like--fetch-remote-resources,--rule,--remediate,--tailoring-file,--tailoring-id, etc.This PR keeps the old
xccdffunction so this shouldn't break or harm anyone that is using the old function of the module.This was partially pushed already at #60712 but that PR got eventually closed without being merged.
Merge requirements satisfied?
Commits signed with GPG?
Yes