Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macpackage state: cleanup temporary mountpoint dir #63905

Merged
merged 6 commits into from
Apr 5, 2023

Conversation

dschaller
Copy link
Contributor

@dschaller dschaller commented Mar 17, 2023

What does this PR do?

modifies the mackpackage state to remove the directory used as a temporary mountpoint for dmg installers

What issues does this PR fix or reference?

Fixes: these directories are orphaned and bloat upon each run

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dschaller dschaller requested a review from a team as a code owner March 17, 2023 21:08
@dschaller dschaller requested review from Ch3LL and removed request for a team March 17, 2023 21:08
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require a changelog and test coverage.

salt/states/macpackage.py Outdated Show resolved Hide resolved
@dschaller
Copy link
Contributor Author

@Ch3LL thanks for the first pass. Updated and should be ready for another look when you have a minute

@Ch3LL Ch3LL merged commit 2bd5526 into saltstack:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants