VMWare Driver does not support tag info

[doesitblend]

Description of Issue/Question

The current cloud vmware driver does not support retrieving information about tags.
Example salt-cloud -a show_instance <instancename> does not display the information about tags. The instance when viewing in vSphere does have tags. If we use the same command in AWS tag info is retrieved and displayed. The tag values are crucial for managing the cloud infra structure.

Setup

(Please provide relevant configs and/or SLS files (Be sure to remove sensitive info).)

Steps to Reproduce Issue

(Include debug logs if possible and relevant.)

Versions Report

Version info:
Salt: 2018.3.4
Vsphere: 6.5

[doesitblend]

ZD-3633

[waynew]

https://vdc-download.vmware.com/vmwb-repository/dcr-public/6b586ed2-655c-49d9-9029-bc416323cb22/fa0b429a-a695-4c11-b7d2-2cbc284049dc/doc/vim.ManagedEntity.html#tag

According to this doc it seems like that might be (currently) an experimental feature. Not sure if it's supported in pyvmomi yet?

[rdutch]

The set of tags associated with this managed entity. Experimental. Subject to change.
Since vSphere API 4.0
I would not call this Experimental

[doesitblend]

Reviewing the current version of pyvmomi (master branch) the tests pull an object containing a key tag.

[...trimmed for brevity..]
"dynamicProperty": [], "dynamicType": null, "key": "host"}, "tag": [], "triggeredAlarmState": [],
[...trimmed for brevity..]

[xeacott]

Upon much investigation, VMWare PyVmomi does not support tagging. This has been stated by tianhao64 in a few github issues that have been opened in pyvmomi, for example:

• Issue 307
• Issue 733

To support this feature, tagging requires vSphere Automation SDK (formerly known as vCloud Suite SDK, which can be viewed here) of version 6.0 at minimum. This is a feature that is being worked on at the moment and will be implemented using the new SDK suite.

[xeacott]

@doesitblend I looked into the salt-cloud command, specifically show_instance and, while we don't have a 1-to-1 command in vsphere.py, there is get_vm that displays information about the virtual machine. I believe this is the method you wish to give associated tags too? There will also be new methods list_tags which will give information about all available tags and, list_attached_tags which will accept a valid virtual machine object and list all attached tags to that object.

[sagetherage]

@doesitblend this is fixed - can you verify using #54058?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[sagetherage]

This is merged @doesitblend ok to close that this will be released in Neon?

[stale]

Thank you for updating this issue. It is no longer marked as stale.