node modules not updated #2964
Comments
|
@th-2021 Could you provide more detail? Do you mean following error on using relative url enabled (that is said that can be safely ignored)? docker log of `sameersbn/gitlab:17.0.3`, setting `GITLAB_RELATIVE_URL=/gitlab` |
|
With relative url set. With make and g++ added I get:
|
|
Well, gcc and make are listed in We have some choise:
The second idea would be acceptable. This may be pointless since we (relative url users) install the necessary node modules at runtime anyway, but I'll write this as advice anyway. I means that I have no plans to create a pull request on this subject at this time. |
|
I tried the upgrades again and the error can be ignored. With one version I had broken assets and thought that this is the issue, but it must have been something different. It worked now. |
|
Is there any version where this doesn't happen? |
|
@shplishka No. More precisely, the root cause of this problem (a situation where gcc and make are required at runtime) is not known. According to @th-2021 's report, it may be caused by corrupted assets but not clear. I've been running gitlab with the relative url feature enabled in all versions since at least 13.10.3 until 17.2.0 (latest version available today), and no such situation occurred on my environment. If you are facing similar issue, providing your detailed setup may help someone who interested in this topic to debug. |
|
I think my issue with broken assets was unrelated to the node modulesAm 24.07.2024 11:10 schrieb Kazunori Kimura ***@***.***>:
@shplishka No. More precisely, the root cause of this problem (a situation where gcc and make are required at runtime) is not known. According to @th-2021 's report, it may be caused by corrupted assets but not clear.
I've been running gitlab with the relative url feature enabled in all versions since at least 13.10.3 until 17.2.0 (latest version available today), and no such situation occurred on my environment.
If you are facing similar issue, providing your detailed setup may help someone who interested in this topic to debug.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thank you for your previous assistance. I am facing another problem related to this behavior. When I use a relative URL in an air-gapped cluster that doesn't have access to npm, Artifactory, etc., the image crashes when it tries to install the node modules. I'm not sure how to resolve this issue. Any advice would be appreciated. |
|
@shplishka Anyway, could you create a new issue about it (relative url does not work if there is no access to npm registry and so on) ? Submitting a merge request is much better. You should just modify the line. diff --git a/assets/build/install.sh b/assets/build/install.sh
index 47fc4620..fb330b23 100755
--- a/assets/build/install.sh
+++ b/assets/build/install.sh
@@ -484,5 +484,5 @@ rm -rf /var/lib/apt/lists/*
# clean up caches
rm -rf ${GITLAB_HOME}/.cache ${GITLAB_HOME}/.bundle ${GITLAB_HOME}/go
-rm -rf /root/.cache /root/.bundle ${GITLAB_HOME}/gitlab/node_modules
+rm -rf /root/.cache /root/.bundle
rm -r /tmp/*I can report how much the image size changes. In any case, the maintainer will make the final decision. You can mention to active maintainer ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During assets compile I get error that some node modules are missing. This is with all newer versions e.g. 17.0.3
The text was updated successfully, but these errors were encountered: