-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Proposal] Automatic Update Integration from GitHub Releases #85
Comments
Hi there, that would be awesome, especially since fdroid cannot reproduce builds (#49) |
Okay bro pr coming soon |
Requested at IzzyOnDroid : https://gitlab.com/IzzyOnDroid/repo/-/issues/636 |
Scanner results:
Easily avoided with a minor addition to your android {
dependenciesInfo {
// Disables dependency metadata when building APKs.
includeInApk = false
// Disables dependency metadata when building Android App Bundles.
includeInBundle = false
}
} For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains. More details can be found e.g. here: Ramping up security: additional APK checks are in place with the IzzyOnDroid repo. Integrating your app now, will report back when done. |
I can confirm the APK is NOT reproducible: If you'd switch to JDK 21, make a test build (from a clean tree, i.e. all changes committed – can be inside a "test branch" but must be available here at Github), then attach the APK here (rename it to Current APK diff: -rw-r--r-- 0.0 unx 120 b- 118 defN 1981-01-01 01:01:02 e9680e28 META-INF/version-control-info.textproto
- -rw-r--r-- 0.0 unx 3885 b- 3885 stor 1981-01-01 01:01:02 0b393429 assets/dexopt/baseline.prof
+ -rw-r--r-- 0.0 unx 3885 b- 3885 stor 1981-01-01 01:01:02 8f7598cf assets/dexopt/baseline.prof
-rw-r--r-- 0.0 unx 498 b- 498 stor 1981-01-01 01:01:02 4012471a assets/dexopt/baseline.profm
- -rw-r--r-- 0.0 unx 2208040 b- 2208040 stor 1981-01-01 01:01:02 f484b8be classes.dex
+ -rw-r--r-- 0.0 unx 2208048 b- 2208048 stor 1981-01-01 01:01:02 8900aa05 classes.dex
-rw---- 2.0 fat 1738 b- 782 defN 1981-01-01 01:01:02 2d73be70 DebugProbesKt.bin ( name : '<init>'
- type : '(LO1/a;ZLY/e;LY/k;)V'
+ type : '(LA/h;ZLY/e;LY/k;)V'
access : 0x10001 (PUBLIC CONSTRUCTOR)
code -
registers : 5
ins : 5
outs : 2
insns size : 13 16-bit code units
-| B.g.<init>:(LO1/a;ZLY/e;LY/k;)V
+| B.g.<init>:(LA/h;ZLY/e;LY/k;)V
|: iput-object v1, v0, LB/g;.j:LO1/a;
|: iput-boolean v2, v0, LB/g;.k:Z
|: iput-object v3, v0, LB/g;.l:LY/e;
@@ -450983,14 +450983,14 @@
Direct methods -
#0 : (in LB/h;)
name : '<init>'
- type : '(JLO1/a;Z)V'
+ type : '(JLA/h;Z)V'
access : 0x10001 (PUBLIC CONSTRUCTOR)
code -
registers : 5
ins : 5
outs : 2
insns size : 11 16-bit code units
-| B.h.<init>:(JLO1/a;Z)V
+| B.h.<init>:(JLA/h;Z)V
|: iput-wide v1, v0, LB/h;.j:J
|: iput-object v3, v0, LB/h;.k:LO1/a;
|: iput-boolean v4, v0, LB/h;.l:Z
@@ -451010,7 +451010,7 @@
registers : 10
ins : 2
outs : 5
- insns size : 67 16-bit code units
+ insns size : 69 16-bit code units
| B.h.k:(Ljava/lang/Object;)Ljava/lang/Object;
|: check-cast v9, LV/c;
|: iget-object v0, v9, LV/c;.i:LV/a;
@@ -451040,9 +451040,10 @@
|: invoke-direct {v2, v4, v7}, Landroid/graphics/PorterDuffColorFilter;.<init>:(ILandroid/graphics/PorterDuff$Mode;)V
|: invoke-direct {v1, v5, v6, v3, v2}, LY/k;.<init>:(JILandroid/graphics/ColorFilter;)V
|: new-instance v2, LB/g;
-|: iget-object v3, v8, LB/h;.k:LO1/a;
-|: iget-boolean v4, v8, LB/h;.l:Z
-|: invoke-direct {v2, v3, v4, v0, v1}, LB/g;.<init>:(LO1/a;ZLY/e;LY/k;)V
+|: iget-boolean v3, v8, LB/h;.l:Z
+|: iget-object v4, v8, LB/h;.k:LO1/a;
+|: check-cast v4, LA/h;
+|: invoke-direct {v2, v4, v3, v0, v1}, LB/g;.<init>:(LA/h;ZLY/e;LY/k;)V
|: invoke-virtual {v9, v2}, LV/c;.b:(LO1/c;)LV/f;
|: move-result-object v9
|: return-object v9
@@ -451101,7 +451102,7 @@
registers : 9
ins : 4
outs : 5
- insns size : 81 16-bit code units
+ insns size : 83 16-bit code units
| B.i.h:(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
|: check-cast v6, LS/o;
|: check-cast v7, LG/q;
@@ -451130,9 +451131,10 @@
|: move-result-object v4
|: if-nez v8, 003b // +0006
|: sget-object v8, LG/l;.a:LG/Y;
-|: if-ne v4, v8, 0043 // +000a
+|: if-ne v4, v8, 0045 // +000c
|: new-instance v4, LB/h;
-|: invoke-direct {v4, v0, v1, v2, v3}, LB/h;.<init>:(JLO1/a;Z)V
+|: check-cast v2, LA/h;
+|: invoke-direct {v4, v0, v1, v2, v3}, LB/h;.<init>:(JLA/h;Z)V
|: invoke-virtual {v7, v4}, LG/q;.g0:(Ljava/lang/Object;)V |
Update: Integration completed, Canta going live at IzzyOnDroid with the next sync around 6 pm UTC: Be welcome to pick a badge to link there e.g. from your Readme 😃 We will establish RB as soon as we can rebuild, see previous comment. |
Added IzzyOnDroid badge with #107. Removed the "Fdroid has old versions only" warning as the version can be viewed from the Readme itself and the specific is already pinned at issue tracker anyway. The IzzyOnDroid |
@shuvashish76 check again, it's blue now that the sync is through. And thanks! Any idea why F-Droid and Github badges have a And @samolego, any word on the RB proposal? No pressure, just for orientation on my end? Thanks in advance! |
For some reason it doesn't work for F-Droid if I remove that...but works for GitHub. |
that's a bit stupid IMHO as it falsifies the versionName – but if that's the only way it works 🤷♂️ PS: Wonder how that looks like for e.g. |
Hi, I'll take a look tomorrow, thanks for all the info but it's quite late here. |
Hi
I hope you're doing well. I’m considering adding a feature to the app that would allow it to show an update dialog when a new release is available on GitHub. The feature would also handle downloading and installing the update directly from within the app.
Would you be open to this enhancement? Please let me know if this is something you'd like to include.
Thank you!
Best regards,
Tamim Hossain
The text was updated successfully, but these errors were encountered: