-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcf: Contig name rules contradiction #711
Comments
The “must not use a reserved symbolic allele name” text was added in c50589b as part of PR #88, in response to @d-cameron's #89 (reformatted here):
The recommended solution to (1) was applied (and later relaxed to allow colons). It says that angle-bracketed strings may not be used as contig names, and is reflected in the current SAM and VCF specs by the rather long RNAME regex — which forbids angle brackets anywhere in contig names. The recommended solution to (2) was applied as the “must not use a reserved symbolic allele name” text you mention. IMHO it's not clear from the VCF text just what this is intended to forbid: a “reserved symbolic allele name” is surely an angle-bracketed thing, so this could be interpreted as forbidding However the context of #89's (2) (as quoted above) suggests that this text really is intended to forbid However I don't understand what issue would be caused for breakend notation such as So I think it would be helpful to revisit this and highlight just what issues, if any, would be caused for such SVs. Then we could either clarify or remove this latter text, as appropriate. |
§ 1.4.7 "Contig field format" states
But subsequently
This means that contig names do not follow the rules as SAM. For example, "DEL" is valid name in SAM but not VCF.
The text was updated successfully, but these errors were encountered: