Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: how to code a GTFCodec beside of the existing GFF3Codec #1613

Closed
lindenb opened this issue Jun 13, 2022 · 1 comment
Closed

Question: how to code a GTFCodec beside of the existing GFF3Codec #1613

lindenb opened this issue Jun 13, 2022 · 1 comment

Comments

@lindenb
Copy link
Contributor

lindenb commented Jun 13, 2022

More a question than an issue.

I would like htsjdk to support the GTF format.

There was a previous discussion about this here #537 . But I think since this thread the htsjdk-next-beta has been forsaken (?) and a GFF3Codec has been included in htsjdk.

Now a GTF codec would be highly similar (and simplier) to the existing GFF3 codec. What would be an acceptable strategy to implement the GTF? My ideas:

  1. copy all the classes Gff3BaseData.java Gff3Constants.java etc... to GtfBaseData.java GtfConstants etc... ?

  2. Keep only Gff3Feature.java but add a new parameter enum GTType {GFF3,GTF} to the constructors . new public Gff3Codec(final DecodeDepth decodeDepth, final Predicate<String> filterOutAttribute,GTType gttype ) {

  3. Add an abstract base class for all the existing GFF3 classes. For example: abstract class AbstractGtXXCodec { and then public class Gff3Codec extends AbstractGtXXCodec and public class GtfCodec extends AbstractGtXXCodec

  4. another idea ?

P.

@lindenb
Copy link
Contributor Author

lindenb commented Mar 16, 2023

closed after : #1662

@lindenb lindenb closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant