Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7 - warning: URI.escape is obsolete #1454

Open
prdanelli opened this issue Sep 30, 2021 · 1 comment
Open

Ruby 2.7 - warning: URI.escape is obsolete #1454

prdanelli opened this issue Sep 30, 2021 · 1 comment

Comments

@prdanelli
Copy link

Hello, firstly, i would like to say thank you for the work you have invested in this project, its very much appreciated.

When using Ruby 2.7 and AF 12.2.x, Ruby gives a deprecation warning:

/usr/local/bundle/gems/active-fedora-12.2.3/lib/active_fedora/file.rb:182: warning: URI.escape is obsolete

According to this Ruby post, https://bugs.ruby-lang.org/issues/17309, the issue could be resolved by replacing all instances of URI.escape with URI::DEFAULT_PARSER.escape.

Is this something that is possible or would be welcomed as a PR?

Thank you,
Paul.

@jcoyne
Copy link
Member

jcoyne commented Sep 30, 2021

Yes, please make a PR if you are able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

2 participants