Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a FileSet's title property isn't set, it should delegate title to its original_file's filename #325

Open
escowles opened this issue Jun 7, 2017 · 0 comments

Comments

@escowles
Copy link
Contributor

escowles commented Jun 7, 2017

You can set a title property on a FileSet, but it's common to have this simply be the original_file's filename. This can get out of sync (e.g., if you replace the content with a file with a different file, the title isn't updated).

We should not set the title explicitly, and if there is no title property set, then we should return the original_file's filename value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant