Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement related objects for generic files if appropriate #86

Open
elrayle opened this issue May 12, 2015 · 6 comments
Open

Implement related objects for generic files if appropriate #86

elrayle opened this issue May 12, 2015 · 6 comments

Comments

@elrayle
Copy link
Contributor

elrayle commented May 12, 2015

If generic files can have related objects, then validate that the behavior is correctly inherited from pcdm:object. (See xit test Related objects -> persists in models/generic_file_spec.rb)

Otherwise, the behavior of adding related objects needs to be blocked in models/concerns/generic_file_behaviors.rb and the block tested.

@jcoyne
Copy link
Member

jcoyne commented May 12, 2015

I thought related objects was out of scope and that further discussion would happen before implementing it.

@jcoyne
Copy link
Member

jcoyne commented May 12, 2015

See discussionhttps://github.com/samvera/hydra-pcdm/pull/66

@jcoyne jcoyne closed this as completed May 12, 2015
@jcoyne jcoyne reopened this May 12, 2015
@elrayle elrayle changed the title Implement related objects for generic objects if appropriate Implement related objects for generic files if appropriate May 13, 2015
@elrayle elrayle added this to the May Hydra PCDM milestone May 13, 2015
@elrayle
Copy link
Contributor Author

elrayle commented May 18, 2015

My understanding from issue samvera/hydra-pcdm#66 was that related files was being postponed. Related object code was already in place and functional from PR samvera/hydra-pcdm#68. This behavior is inherited from Hydra::PCDM. Tests were added with PR #96. The ability to add related objects is now provided by services. See PR #106. Tests for related objects moved from model tests to service tests with this PR.

If GenericFiles should not have related objects, then this functionality will need to be blocked.

@mjgiarlo mjgiarlo added the pcdm label Jul 9, 2015
@mjgiarlo mjgiarlo modified the milestones: May Hydra PCDM, Summer 2015 Sprint, summer-2015 Jul 9, 2015
@grosscol
Copy link
Member

grosscol commented Aug 4, 2015

The related objects is being addressed again during the tech call on 2015-08-05.

@mjgiarlo
Copy link
Member

mjgiarlo commented Jun 1, 2016

Refs samvera-deprecated/sufia#1711

@jrgriffiniii
Copy link
Contributor

This is still being addressed in a forthcoming release of Hyrax: samvera/hyrax#116. It may also be deprecated by the Collections Extensions work (please see samvera/hyrax#116 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants