Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build to fails due to openjph type changes #3

Open
michaeldsmith opened this issue Feb 19, 2022 · 1 comment
Open

build to fails due to openjph type changes #3

michaeldsmith opened this issue Feb 19, 2022 · 1 comment

Comments

@michaeldsmith
Copy link

Several months ago, openjph made many type changes for example converting int to unsigned int in various places. Perhaps the type change from int to uint is causing the openhtjs build to fail now, I get this error when running npm run build

#10 4.713 In file included from /src/src/cpp/HT_internal.cpp:17:
#10 4.713 /src/src/cpp/HTDecoder.hpp:162:51: error: non-const lvalue reference to type 'ojph::ui32' (aka 'unsigned int') cannot bind to a value of unrelated type 'int'
#10 4.713     ojph::line_buf* line = this->codestream_.pull(this->compNum_);
#10 4.713                                                   ^~~~~~~~~~~~~~
#10 4.713 /src/external/OpenJPH/src/core/common/ojph_codestream.h:96:26: note: passing argument to parameter 'comp_num' here
#10 4.713     line_buf* pull(ui32 &comp_num);
#10 4.713                          ^
#10 4.814 1 error generated.
@michaeldsmith
Copy link
Author

quick fix is to go back to older version of OpenJPH
from external/openjph
git checkout tags/0.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant