Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep copy needed before each scaling in predict_subset() method of pvops/timeseries/models/AIT.py #98

Open
agmoore4 opened this issue Sep 11, 2024 · 0 comments · May be fixed by #100
Open

Comments

@agmoore4
Copy link
Contributor

Currently, when new standardized columns are created, the original columns are also standardized. This results in the R2 and logRMSE being calculated between the predicted unscaled energy and the true scaled energy, suggesting (incorrectly) that the model performs poorly.

There is a deep copy at the start of the method, but it doesn't do anything. The deep copy needs to happen inside the for-loop before each standardization is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant