Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visual-editing): add package version mismatch warning #2040

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

rdunk
Copy link
Member

@rdunk rdunk commented Oct 24, 2024

This adds a new warning message about package version mismatching when visual editing doesn't receive a response to a features request. This replaces all the individual warnings emitted by other requests used to support new features (e.g. fetching the schema) when these are not supported by the user's Presentation version.

@rdunk rdunk requested a review from a team as a code owner October 24, 2024 12:38
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-visual-editing-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-next-with-i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-page-builder-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am
visual-editing-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:38am

@rdunk rdunk merged commit c112de4 into main Oct 24, 2024
20 checks passed
@rdunk rdunk deleted the feat/mismatch-warning branch October 24, 2024 12:52
@ecospark ecospark bot mentioned this pull request Oct 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants