Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segfault in current master #40

Closed
deanmao opened this issue Aug 24, 2012 · 3 comments
Closed

segfault in current master #40

deanmao opened this issue Aug 24, 2012 · 3 comments

Comments

@deanmao
Copy link

deanmao commented Aug 24, 2012

FYI, I tried merging the new libsass into our current node-sass repo that uses it. Something added in recently caused it to segfault. When I run it through gdb, it complains on this line:

string path_string(img_path_str);

This line is found in context.cpp on line 63. I haven't had time to investigate it, but it looks like this was new code added in a few hours ago.

@akhleung
Copy link

Oops, the API has changed slightly -- the sass_options struct now has a field for the path where image assets are located; this is used by the image-url function to automatically splice together paths to images. I'll add a null check to prevent the segfault in the event that the image_path field isn't set.

@akhleung
Copy link

All right, made the fix. Please try the latest master.

@deanmao deanmao closed this as completed Aug 24, 2012
@deanmao
Copy link
Author

deanmao commented Aug 24, 2012

Looks good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants