Prevent NoClassDefFoundError crashing app using Sugar #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rName can also throw LinkageError and ExceptionInInitializerError. If we silently ignore a ClassNotFoundException, I don't see why we wouldn't ignore the others. A NoClassDefFoundError coming out of this method was causing my application to crash, but it was actually fine that the class couldn't be loaded.
|
@nicolabeghin thanks, I will merge this PR |
sibelius
added a commit
that referenced
this pull request
Dec 7, 2015
Prevent NoClassDefFoundError crashing app using Sugar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Satya,
I'm just getting started using Sugar ORM and it looks really good so far. However, I had trouble getting my app to run because I kept getting a NoClassDefFoundError when I included Sugar.
I had a jar file on my classpath which wasn't actually being used by the project. When Sugar tried to load a class from that library, my app crashed.
My guess is that because the library was not being used, the classes didn't actually get copied to the apk, or something like that.
I changed the catch clause in getDomainClass to catch all throwables. It doesn't seem to matter why we can't load a class, the result will be the same: if there is an error of any kind, we're not going to be able to use that class as a domain class.
Thanks,
Alex