Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument error on logging adapter warning. #22

Closed
khy opened this issue Mar 7, 2011 · 3 comments
Closed

Argument error on logging adapter warning. #22

khy opened this issue Mar 7, 2011 · 3 comments
Labels

Comments

@khy
Copy link

khy commented Mar 7, 2011

Noticed this using Savon - the error appears to affect only the 0.8.0 release.

In the 0.7.x series, HTTPI::Adapter would use the HTTPI.log proxy logging method, which takes an argument splat. In 0.8.0, it uses HTTPI.logger.warn which takes only one argument - since two strings are still being passed, an ArgumentError is raised.

ArgumentError: wrong number of arguments (2 for 1)
from .../vendor/bundler_gems/ruby/1.8/gems/httpi-0.8.0/lib/httpi/adapter.rb:60:in `warn'
from .../vendor/bundler_gems/ruby/1.8/gems/httpi-0.8.0/lib/httpi/adapter.rb:60:in `load_adapter'
from .../vendor/bundler_gems/ruby/1.8/gems/httpi-0.8.0/lib/httpi/adapter.rb:45:in `find'
from .../vendor/bundler_gems/ruby/1.8/gems/httpi-0.8.0/lib/httpi.rb:186:in `with_adapter'
from .../vendor/bundler_gems/ruby/1.8/gems/httpi-0.8.0/lib/httpi.rb:84:in `get'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/request.rb:21:in `response'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/request.rb:30:in `with_logging'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/request.rb:21:in `response'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/document.rb:93:in `http_request'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/document.rb:77:in `document'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/document.rb:105:in `parser'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/wsdl/document.rb:38:in `endpoint'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/client.rb:108:in `preconfigure'
from .../vendor/bundler_gems/ruby/1.8/gems/savon-0.8.6/lib/savon/client.rb:74:in `request'
@rubiii
Copy link
Contributor

rubiii commented Mar 8, 2011

thanks for reporting this. made a mistake in pushing this out too early. i'll publish a fixed version tomorrow!

@khy
Copy link
Author

khy commented Mar 8, 2011

No problem. Thanks for making savon - it's an awesome gem.

@rubiii
Copy link
Contributor

rubiii commented Mar 8, 2011

thanks :) v0.9.0 should fix this problem. please take a look at the new CHANGELOG for information about the release.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants