-
Notifications
You must be signed in to change notification settings - Fork 184
Upper bounds on supported Julia versions #570
Comments
The thing is, we don't know if/when LG will break on an unsupported version of Julia. The way we handle this is to be explicit in cc @tkelman since I seem to revisit this issue every 3-4 months. |
Once at least one tagged version is available that does work on nightly, it could make sense to upper-bound all the past tagged versions at whichever first Julia release they won't work on. If there isn't at least one version available without an upper bound, then the package (and all its dependents) won't be installable at all on nightly. |
@tkelman is it okay to only do that with a PR to METADATA and not go back and edit REQUIRE in the repo? |
Yes, bounds do need to be updated retroactively once in a while, but sha's should be left alone. For registered packages at a tagged version, the METADATA requires file content takes priority over the package REQUIRE file content. |
OK, so I think the plan you're implying is this:
Does that sound right? |
One PR for adding upper bounds to all the past versions would be preferable. I can help out with that when you're ready. That plan sounds good to me. |
Though for step 2, what you put as the lower bound of an 0.6-only tag will depend on when it comes out relative to when Julia 0.6.0 final comes out. If you're ready before Julia is, you could set an alpha/beta/rc as your minimum. |
Got it. We are ready now, but the issue is that there's really no guarantee that what works on the alpha version will work on the release, right? That seems to argue for putting the alpha version in the LightGraphs 0.8 REQUIRE and making any adjustments necessary when Julia 0.6 is released. |
Closing this out in favor of #573 and JuliaLang/METADATA.jl#8817. |
Right now LightGraphs supports
julia 0.5
, which means any Julia release greater than or equal to the first 0.5 release. Therefore, 0.7.X versions declare that they work on 0.6, which they do not. It's probably too complicated to both edit METADATA and the repo's REQUIRE file, but this might be a good idea for future versions like #541 .The text was updated successfully, but these errors were encountered: