Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "limit" param for "zip bomb" protection #251

Open
xuwei-k opened this issue Jul 18, 2019 · 1 comment
Open

add "limit" param for "zip bomb" protection #251

xuwei-k opened this issue Jul 18, 2019 · 1 comment

Comments

@xuwei-k
Copy link
Member

xuwei-k commented Jul 18, 2019

https://en.wikipedia.org/wiki/Zip_bomb

d258f90

WDYT? 👀
@eed3si9n
Copy link
Member

It sounds like a good idea, but we should make sure that the default is large enough, and that user can override it somehow. Sometimes the files we handle could become really large, like JSON file containing an UpdateReport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eed3si9n @xuwei-k