Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default JDK change: revert or yell from the mountaintops #96

Open
rossabaker opened this issue Dec 6, 2021 · 1 comment
Open

Default JDK change: revert or yell from the mountaintops #96

rossabaker opened this issue Dec 6, 2021 · 1 comment

Comments

@rossabaker
Copy link
Contributor

The default JDK changed from 8 to 11 in 0.14.0, which isn't noted in the changelog and probably not what most people want. Lots of people are getting Scala Steward upgrades to sbt-spiewak-0.23 and ending up on Temurin 11, and probably not realizing it.

@mdedetrich
Copy link
Contributor

My argument to this would be that if you don't want JDK to update itself to the latest LTS release then you can set githubWorkflowJavaVersions and it will never happen. For majority of software, updating to latest LTS JDK release is desirable and githubWorkflowJavaVersions exists to override this behaviour.

I also don't see how this is any different to, lets say, JDK versions silently updating when using github actions (i.e. you specify JDK 11 but not the minor version, and this will also silently update whenever the github action does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants