Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka archetype bat script needs major rework #521

Closed
jroper opened this issue Mar 10, 2015 · 8 comments
Closed

Akka archetype bat script needs major rework #521

jroper opened this issue Mar 10, 2015 · 8 comments
Labels
universal Zip, tar.gz, tgz and bash issues windows

Comments

@jroper
Copy link
Member

jroper commented Mar 10, 2015

See

https://github.com/sbt/sbt-native-packager/blob/0b3516496467f316660bcedf4463c5308fb83af4/src/main/resources/com/typesafe/sbt/packager/archetypes/akka-bat-template

  • JAVA_OPTS is hard coded, with no possibility to override it with custom memory or JVM arguments.
  • The main bat script contains a lot of very useful functionality, such as logic for locating the right Java version, logic for configuring using environment variables, etc, which is missing from this template.

The bash script suffers from similar problems, but at least it doesn't hard code JAVA_OPTS with no possibility to override.

@muuki88 muuki88 added windows universal Zip, tar.gz, tgz and bash issues labels Mar 10, 2015
@muuki88
Copy link
Contributor

muuki88 commented Mar 10, 2015

Could we customize the existing bash/bat scripts in a way suitable for Akka kernel apps? So we only have to maintain one start script. WDYT?

@jroper
Copy link
Member Author

jroper commented Mar 10, 2015

I think that would be a great way to do it.

@patriknw
Copy link

We (Akka Team) would like to remove the AkkaAppPackaging and instead document a migration path to JavaServerAppPackaging in the Akka documentation. Something like akka/akka#17065.

Next step would be to document a clean usage of JavaServerAppPackaging and an ordinary main class for packaging and running an Akka application. Nothing special as far as I can see.

WDYT about removing AkkaAppPackaging?

@muuki88
Copy link
Contributor

muuki88 commented Mar 27, 2015

There's no flexible code as no code

So I'm all about removing if we have to maintain less bash/scala/sbt code without losing any functionality.

@muuki88
Copy link
Contributor

muuki88 commented Apr 17, 2015

We deprecated AkkaPackaging and will remove it.

@muuki88 muuki88 closed this as completed Apr 17, 2015
@kardapoltsev
Copy link
Member

@muuki88, could you remind relevant discussion? I recently tried to find it and failed..

@patriknw
Copy link

Thanks! We have updated the Akka documentation to recommend the JavaServerAppPackaging.
http://doc.akka.io/docs/akka/snapshot/intro/deployment-scenarios.html

@muuki88
Copy link
Contributor

muuki88 commented Apr 20, 2015

Awesome, thanks @patriknw

@kardapoltsev No, everything came a bit abruptly. However this is the better way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
universal Zip, tar.gz, tgz and bash issues windows
Projects
None yet
Development

No branches or pull requests

4 participants