Xml Transformation Inheritaance

[scabug]

at package scala.xml.transform you've got 3 classes

abstract class BasicTransformer extends Function1[Node,Node]
class RuleTransformer extends BasicTransformer
class RewriteRule extends BasicTransformer 

I think you can make RewriteRule as separate abstract class, because it is inheritance isn't necessary and overcomplicate code.

[scabug]

Imported From: https://issues.scala-lang.org/browse/SI-4529?orig=1
Reporter: Alex Kolonitsky (alex.kolonitsky)

[scabug]

@dcsobral said:
Both RuleTransformer and RewriteRule depend on the basic engine of def transform(ns: Seq[Node]): Seq[Node]. Perhaps a better question is why have a RuleTransformer at all. The only thing it does different is not recursing on descendants inside def transform(n: Node): Seq[Node], which makes it possible to make an inheritance chain from RuleTransformer, and know it will stop at the identity implementation on RuleTransformer.

Since RuleTransformer does use the recursing characteristic of BasicTransformer, the safety net provided by RuleTransformer provides a certain guarantee of avoiding exponential explosions.

So, overall, I don't think breaking the inheritance here would make things easier instead of harder.

[scabug]

@SethTisue said:
The scala-xml library is now community-maintained. Issues with it are now tracked at https://github.com/scala/scala-xml/issues instead of here in the Scala JIRA.

Interested community members: if you consider this issue significant, feel free to open a new issue for it on GitHub, with links in both directions.