Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release another 1.1.x version? #189

Closed
SethTisue opened this issue Feb 13, 2019 · 11 comments
Closed

release another 1.1.x version? #189

SethTisue opened this issue Feb 13, 2019 · 11 comments

Comments

@SethTisue
Copy link
Member

this came up at #180

separately, #188 asks about branching for 1.2.x

@SethTisue
Copy link
Member Author

SethTisue commented Feb 27, 2019

another reason to do a release is Scala Native, #141

@lolgab if there were any difficulties releasing for Scala Native would you try to help? (asking because of
etorreborre/specs2#591 (comment))

@gourlaysama any objections to doing a release?

@Philippus would be interested in writing release notes and attempting the publishing?

@lolgab
Copy link
Contributor

lolgab commented Feb 27, 2019

I'm glad to help if I can. I published my first artifact yesterday (scalacheck native) and seen this as indirect dependency of cats, published it too (I were in publishing mood :D). So, sorry for being rude and not asking an official release before publishing.

@SethTisue
Copy link
Member Author

no worries, I mean, this has been pending for ages and ages now. I think you did the right thing to get other projects moving.

@SethTisue
Copy link
Member Author

another reason to do another 1.1.x release is to switch over to publishing from JDK 8 (though still building/testing on JDK 6 to ensure JDK 6 compatibility) from dependencies retrieved via https only, as per
scala/sbt-scala-module#41 (comment)

@Philippus
Copy link
Member

Philippus commented Apr 5, 2019

proposal for release notes:

Release notes v1.1.2

Scala-parser-combinators 1.1.2 is now available!

Changes in this release:

#193 Scala 2.13.0-RC1 is now supported
#184 Update license to Apache 2.0
#180 Fix StackOverflowError in Page.latest
#179 Fix StackOverflowError in PagedSeq.fromString
#174 Re-add support for Scala native
#164 Support '\r' and '\r\n' line endings
#162 Add 'exception' operator

It is available for Scala 2.11, 2.12 and 2.13.0-RC1:

libraryDependencies += "org.scala-lang.modules" %% "scala-parser-combinators" % "1.1.2"

And for Scala-js 0.6.x:

libraryDependencies += "org.scala-lang.modules" %%% "scala-parser-combinators" % "1.1.2"

A big thank you to everyone who contributed to this release!
According to git shortlog -sn --no-merges v1.1.1..v1.1.2, 6 people contributed to v1.1.2: Umayah Abdennabi, Philippus Baalman, Antoine Gourlay, Filip Ochnik, Seth Tisue, Sarunas Valaskevicius.

@SethTisue
Copy link
Member Author

LGTM

@SethTisue
Copy link
Member Author

1.1.2 release job isn't able to upload to Sonatype, let's dive into that on a separate ticket (#194)

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

inspected contents, all nine combos present (2.11/2.12/RC1 x JVM/sjs0.6/sjs1)

Screen Shot 2019-04-05 at 11 13 05 PM

hit "close" in web UI

hit "release"

now we watch https://repo1.maven.org/maven2/org/scala-lang/modules/scala-parser-combinators_2.13.0-RC1/1.1.2/

@SethTisue
Copy link
Member Author

@Philippus
Copy link
Member

we should look at releasing this tag for scala native, but not today. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants