Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sbt is not able to build with java 1.7 #86

Closed
biswanaths opened this issue Oct 21, 2015 · 4 comments
Closed

Sbt is not able to build with java 1.7 #86

biswanaths opened this issue Oct 21, 2015 · 4 comments

Comments

@biswanaths
Copy link
Contributor

On a system with java 1.7, sbt is not able to figure which scala version to use. The reason are the following line from build.sbt. As you can see there is no condition for java 1.7, and it gives the error "don'know what Scala versions to build on $java". Please see https://github.com/scala/scala-xml/blob/master/build.sbt#L11

crossScalaVersions         := {
  val java = System.getProperty("java.version")
  if (java.startsWith("1.6."))
    Seq("2.11.7", "2.12.0-M1")
  else if (java.startsWith("1.8."))
    Seq("2.12.0-M2")
  else
    sys.error(s"don't know what Scala versions to build on $java")
}
@SethTisue
Copy link
Member

Note that any change must interact properly with .travis.yml; see 38fbbbe.

I guess it should lump 1.7 in with 1.6? (And, while we're at it, lump 1.9 in with 1.8?)

@biswanaths
Copy link
Contributor Author

@SethTisue , Can you expand " change must interact properly with .travis.yml" ?

If we add a condition for java1.7 I don't even see a problem with test we are not even testing for java 1.7. Also is there a reason, why tests1.7 are removed.

I will go ahead and 1.7 to 1.6 and 1.9 to 1.8 .

@SethTisue
Copy link
Member

there would only be a problem with .travis.yml if someone were contemplating a more drastic change to the crossScalaVersions logic. I just wanted to remind y'all where the current logic came from.

is there a reason, why tests1.7 are removed

it just seemed like overkill (slower feedback from Travis, and probably no gain., but I don't have a strong feeling about it one way or the other. you could re-enable it if you see value in it.

@biswanaths
Copy link
Contributor Author

Ok, submitted a pr for the same.

1.9 already. I hardly know anything about 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants