Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find less fragile alternative to .tastycheck testing #21255

Open
bishabosha opened this issue Jul 24, 2024 · 0 comments
Open

find less fragile alternative to .tastycheck testing #21255

bishabosha opened this issue Jul 24, 2024 · 0 comments
Labels
area:tasty-format issues relating to TASTy as a portable standard area:testing itype:enhancement

Comments

@bishabosha
Copy link
Member

in PRs #19827, #21001, and #21214 we use the concept of a .tastycheck file to validate the exact format of tasty. This testing method was introduced because without it there was no testing method to validate precisely what TASTy is produced. - for example to identify which trees get generated or elided, or which source paths exist.

Unfortunately it's likely to be brittle - already test files are fragile to changes in type inference - so that must be avoided - and we already elide machine/config specific information such as source files, compiler version and uuid in the tasty header.

So we should either make it more customisable so that only a specific section of TASTy gets rendered, or perhaps develop a new DSL that can perhaps assert the absence of information, rather than enforcing stability of detail that is otherwise noise in a check file.

@bishabosha bishabosha added stat:needs triage Every issue needs to have an "area" and "itype" label area:testing itype:enhancement area:tasty-format issues relating to TASTy as a portable standard and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tasty-format issues relating to TASTy as a portable standard area:testing itype:enhancement
Projects
None yet
Development

No branches or pull requests

1 participant