Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extends path syntax #143

Open
nicolasstucki opened this issue Sep 7, 2020 · 2 comments
Open

Improve extends path syntax #143

nicolasstucki opened this issue Sep 7, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@nicolasstucki
Copy link
Contributor

@MaximeKjaer:

Two small things stand out to me here:

  1. The dots aren't highlighted. I think we should aim to highlight the dots in the qualified name as punctuation, like we do for qualified names in imports.
  2. The package names are highlighted as scala.source, whereas they are highlighted as entity.name.import.scala for imports. With my editor theme, package names show up as yellow in imports, and white in extends. Should we aim to unify the two? For instance, the package names in extends could be entity.name.scala.

Different highlightings for package names in import and extends

@nicolasstucki nicolasstucki added the enhancement New feature or request label Sep 7, 2020
@nicolasstucki
Copy link
Contributor Author

It seems to be simple to identify where to color the paths when we extend with extends or with but it might be trickier when we use the new , syntax.

class Foo extends Bar, Baz

@MaximeKjaer
Copy link
Contributor

I think we may need the extends keyword to push us into a new state, say #parent-classes. Would there always be a clear end token to this state, like : or {, or could it end with a newline with the new syntax?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants