-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to submit multiple, independent projects? #84
Comments
Thanks for opening this issue. It should indeed be possible to submit multiple independent projects but currently it is not. The problem is that currently all manifests are declared as coming from a single build file sbt-dependency-submission/sbt-plugin/src/main/scala/ch/epfl/scala/GithubDependencyGraphPlugin.scala Lines 186 to 187 in 04f2579
I think we can fix this by comparing the sbt |
@adpi2 Thanks! Would be nice to have this working 😉 |
Thanks for fixing. However how does that actually work now? ...
steps:
- uses: actions/checkout@v3
- uses: scalacenter/sbt-dependency-submission@v2
with:
working-directory: ./my-scala-project-one
- uses: scalacenter/sbt-dependency-submission@v2
with:
working-directory: ./my-scala-project-two Or does the action detect all |
Yes you still need to run a separate step for each project. The fix is released in 2.2.1. @mkurz Could you test that it works as expected? |
It seems that Github only takes into account the latest snapshot of a job. See for instance, this job submitted three snaphsots but only one is displayed in the Dependency Graph view |
@adpi2 Exactly, see my comment playframework/play-mailer#250 (comment) |
@mkurz, thanks for the comment. Being able to send the manifests of several build in a single snapshot would require quite some changes in the architecture of the action. I could try it but I think there is a simpler fix. Currently we use the pair GITHUB_RUN_ID and GITHUB_JOB as identifier of a snapshot. In your job there are possibly both the same and that would be why the snapshots get overwritten. |
Found some interesting documentation about that problem:
|
@mkurz If you can try again to run your dependency submission that would be very helpful |
Sorry for my ignorance in case that is possible anyway and I just couldn't figure it out or was misconfiguring things or was discussed already.
Let's say I have a repository with two independent projects
project_a/build.sbt
andproject_b/build.sbt
.Can I submit both of those
build.sbt
files to GitHub so they show up independent in the /network/dependencies view?I tried that with the Play Framework were we have a
build.sbt
and adocumentation/build.sbt
, but in the GitHub UI only thebuild.sbt
shows up.The workflow: https://github.com/playframework/playframework/blob/3c21f31f28c27ad00c9495096fa60e25a4b67050/.github/workflows/dependency-graph.yml#L24-L27
I think this has to be possible somehow because in our Dependency UI it shows all our (multiple) yml workflow files already.
The text was updated successfully, but these errors were encountered: