-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with React #11
Comments
Hey! Much appreciated! |
Very interested. From where can we start? Have you got updates about this? |
@luisnomad Hey! I'm in for contributing to the idea. Have you gotten somewhere with this so far so that I would know to start a fresh or join you from where you are right now |
@luisnomad @hooram @claudioviola I began to work on this. Any contributions from you will be helpful |
@porsamini great! Thanks I see in your repo it's not possible leave any issue. What do you think about pagination features, allow images selectable and open a lightbox for show the image in fullscreen? |
I just added issues tab Lightbox is on my mind too. If you notice the changes in the forked repo, you can see onClick method has been added to facilitate this feature. I must continue working on this after I get the test cases ready and publish it. I've planned to write another react plugin which should exactly look like facebook's lightbox(image on the left and text contents on the right) and integrate that into pig.js I was working on AJAX but it was consuming too much time for me to implement the onScroll feature. Have you worked on this onScroll feature before? |
@porsamini When you talk about to implement onScroll feature you are talking about pagination when the y scroll value get the bottom? |
Yes, I looked at it but I didn't really find my purpose as I wanted the image on the left and any html content on the right. So, I will come up with a new plugin for it
Yep. I tried this with If you make any developments on these remaining items, fire me an email and we can chat up on Hangouts |
I'll also throw my hat into the ring for this feature. I've created a package which re-implements Pig's logic into a React component, with a few extra features added. https://github.com/nickmcmillan/pig-react Each image is clickable and expands to fill the center of the screen. I've used React Spring to handle the transition. Instead of hosting images locally and keeping multiple versions at different dimensions I've used an image hosting service instead which can handle resizing on the fly. Overall the performance looks quite good. I've put up a demo site here https://pigreact.netlify.com/ I'd love to know if anyone finds it helpful! |
### This is Awesome! |
Hi there!
I have used your PIG library and it rocks big time. I have half-integrated it within a React project, and now it's time to refactor it so it doesn't use document.createElement anymore, calling React.createElement instead. I bet it's going to be fun.
If anyone is interested in participating or playing around with it, let me know. I am using this as an exercise to really learn React, so I am no expert. I hope doing this will change that 😄
The text was updated successfully, but these errors were encountered: