[Enhancement] Properties without setter are read-only

[madebyherzblut]

When I set the annotation @Accessor(getter="foo") on a property I expect this property to be read-only.

Example:

<?php

class ObjectType
{
    /**
     * @Serializer\Type("integer")
     * @Serializer\Accessor(getter="getId")
     */
    protected $id;
}

$types = $serializer->deserialize(
  '[{"id":123123,"bundle":"TestBundle","controller":"TestController"}]',
  'array<ObjectType>',
  'json'
 );

Result:

object(ObjectType)[58]
      protected 'id' => int 123123
      protected 'name' => null
      protected 'bundle' => string 'TestBundle' (length=10)
      protected 'controller' => string 'TestController' (length=14)

I could skip some validation/cleaning logic if id is never set by deserialize.

[schmittjoh]

The accessor annotation just changes the way the value is retrieved. If you need to exclude something, then you can use the @exclude annotation on the id property, or a custom exclusion strategy.

[madebyherzblut]

@Exclude wouldn't work because I would like to include this property when the object is serialized (therefore "read-only"). A custom exclusion strategy is indeed an option, although it requires more code than the suggest enhancement.

[schmittjoh]

I understand your proposal, but it's a different layer. Maybe serialization groups would help you, or we could add another annotation, sth like @readonly.

[ruudk]

So there's no solution for this right now? I want the exact same thing and @exclude wont help because I want it when I serialize the object.

[ruudk]

Another way of fixing this would be by removing the exception and just return.

if (!$metadata->type) {
  //throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $metadata->reflection->getDeclaringClass()->getName(), $metadata->name));
  return;
}

Maybe making it optional via config?

[schmittjoh]

There are basically two solutions that I see:

1. Add a @readonly annotation
2. Add support for @group (which I think is better as it is more generic, and not tied to this specific use-case)